Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add block: Preformatted/Code #516

Closed
ellatrix opened this issue Apr 26, 2017 · 3 comments
Closed

Add block: Preformatted/Code #516

ellatrix opened this issue Apr 26, 2017 · 3 comments
Assignees
@ellatrix
Labels
[Feature] Blocks Overall functionality of blocks Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Task Issues or PRs that have been broken down into an individual action to take
Milestone
May Week 4: Beta

Comments

@ellatrix
Copy link
Member

ellatrix commented Apr 26, 2017 •
edited
Loading

I'm seeing this block in the mockups, but no issue, so here is one for tracking. :)

Feel free to replace the description.
@ellatrix ellatrix added Framework Issues related to broader framework topics, especially as it relates to javascript [Type] Task Issues or PRs that have been broken down into an individual action to take Good First Issue An issue that's suitable for someone looking to contribute for the first time labels Apr 26, 2017
@jasmussen
Copy link
Contributor

Nice. Here are the mockups I have for it.

Neutral:

code neutral

Hover:

code hover

Selected:

code selected

@ellatrix
Copy link
Member Author

Looks good! One thing we might have to do (and makes a lot of sense) is splitting this into a preformatted block and a real code block. Preformatted is often used, not for code, but just to format the text e.g. for poetry.

The difference in markup is:

<pre>text</pre>
<pre><code>code</code></pre>

@mtias mtias added [Feature] Blocks Overall functionality of blocks and removed Framework Issues related to broader framework topics, especially as it relates to javascript labels May 3, 2017
@georgeh georgeh assigned georgeh and unassigned georgeh May 3, 2017
@jasmussen jasmussen added this to the Alpha milestone May 10, 2017
@ellatrix ellatrix self-assigned this May 17, 2017
This was referenced May 17, 2017
Merged
Merged
@jasmussen jasmussen modified the milestones: May Week 3 (Alpha), Beta May 22, 2017
@ellatrix
Copy link
Member Author

Both are merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ellatrix ellatrix

Labels
[Feature] Blocks Overall functionality of blocks Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Milestone
May Week 4: Beta
Development

No branches or pull requests
4 participants
@georgeh @mtias @jasmussen @ellatrix