Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown active option indicator misaligned #52001

Open
dcalhoun opened this issue Jun 28, 2023 · 5 comments
Open

Dropdown active option indicator misaligned #52001

dcalhoun opened this issue Jun 28, 2023 · 5 comments
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Regression Related to a regression in the latest release

Comments

@dcalhoun
Copy link
Member

Description

The indicator for the currently selected option within a dropdown menu is misaligned.

This appears to have been introduced in the 22.5 release via #50665 or #50907.

Step-by-step reproduction instructions

  1. Add a Heading block1.
  2. Tap the "Change level" button (an H2 icon) to open the heading level dropdown menu.

Expected behaviour

The check mark indicating the selected option is flush to the right.

Actual behaviour

The check mark indicating the selected option is slightly to the right of center.

Screenshots or screen recording (optional)

Correct (22.4) Incorrect (22.5)
alignment-correct alignment-incorrect

WordPress information

  • WordPress version: 6.2.2
  • Gutenberg version: 16.0.0
  • Are all plugins except Gutenberg deactivated? Yes
  • Are you using a default theme (e.g. Twenty Twenty-One)? Yes

Device information

  • Device: iPhone 13 mini
  • Operating system: iOS 16.5.1
  • WordPress app version: 22.5

Footnotes

  1. Reproducing via heading level may not be possible due to https://github.com/WordPress/gutenberg/issues/51996, but this can be reproduced via block or text alignment dropdown menus as well.

@dcalhoun dcalhoun added [Type] Regression Related to a regression in the latest release Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels Jun 28, 2023
@dcalhoun
Copy link
Member Author

@fluiddot not a disruptive or new regression, but it appears this may be the result of recent changes to the Cell component.

@dcalhoun dcalhoun added the [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later label Jun 28, 2023
@fluiddot
Copy link
Contributor

@fluiddot not a disruptive or new regression, but it appears this may be the result of recent changes to the Cell component.

That's interesting. In the tests we made when updating the Cell component, we covered the different components that used it. However, seems I overlooked DropdownMenu. I'll try to take a quick look in the next few weeks to plan a fix, maybe we could use the RadioControl component as a replacement here 🤔.

@dcalhoun dcalhoun added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Sep 15, 2023
@devmuhib009
Copy link
Member

devmuhib009 commented Sep 17, 2023

I just checked in my android mobile, heading display label the label at the top. There is no check mark on android.
Gutenberg Mobile

@devmuhib009
Copy link
Member

As heading label displaying at the top of H2 heading, it does not allow to select the H2 heading in mobile. I tried to select the H2 heading in various way, but once I change heading from H2 to another, I can't get back to original one.

@fluiddot
Copy link
Contributor

Hey @devmuhib009, thanks for chiming in 👋 . Per the screenshot you shared, it appears you are using the Gutenberg editor in the browser. The original issue only affects the mobile native version of the editor, which is embedded in the WordPress/Jetpack app. Hence, it can only be reproduced using the app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

No branches or pull requests

3 participants