-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synced patterns: indicate trashed and draft status in the editor #52013
Comments
@WordPress/gutenberg-design for more thoughts. This feels like something to iterate on for 6.3 as well but curious what others think. |
I suppose this behavior is consistent with the old reusable block experience, so not really a "new" problem? That makes me wonder how urgent it is to fix. Template parts behave the same way as well. That's not to say we shouldn't polish if there are good ideas. A couple of questions to ponder:
|
I think @jameskoster brings up an important point about the draft mode, and that is probably a decision that needs to be made as soon as possible, it might be more difficult to change, the longer we wait? Other than that I don't think UI changes for showing the state needs to be prioritised for 6.3. |
For me it seems mostly a technical question, can the draft status even be removed? If yes, I'd agree that there doesn't seem to be a compelling use case for draft RBs. |
Just landed on this issue while researching existing issues about the "Draft" status for Patterns. I talked to a user who got used to accessing the deprecated WP Admin screen for patterns (they bookmarked the URL) and they made use of status in Patterns heavily to distinguish between patterns they were using on the site and patterns that were no longer in use but they still wanted to keep on the site in case they ever need it again. While not the most common use case, I see some benefit in having a way to hide patterns from the inserter by switching their status, but keeping them archived on the site for safekeeping. Another possible use case is builders/agencies wanting to hide patterns from clients while they are not ready to be used. |
To be responsible with existing sites, a good question to ask first is, what happens if you do this today? If the pattern remains even if the source turns to draft, backwards compatibility might simply spell out some rules for us. But if the pattern becomes invisible also on the frontend, when the status changes, then that suggests your idea could work. |
It is the "classic" pattern screen that has the draft and move to trash options. Edit: If you are testing this with a pattern created on 6.6, you can for example trash and then restore a pattern. |
Thanks. I still see two parts to this, probably to be handled separately:
|
I don't mind the draft status showing in the toolbar, but I can understand if there are objections to it being that prominent. |
Okay so the action items would be;
Want to update the OP with the designs? |
What problem does this address?
Synced patterns that have been published and placed in content, but then set to draft or trashed, display in the editor but not on the front.
It is not possible to see the pattern's status in the editor.
The only visual difference between a published pattern and the draft/trashed is that the pattern-specific name is not used in the list view:
The text was updated successfully, but these errors were encountered: