Update dependencies of @wordpress/scripts to fix semver security issue

[rosswintle]

I'm not sure how to raise this as it doesn't seem to fit one of the issue types that has a template.

We have a number of repositories that use @wordpress/scripts.

These all have Dependabot reporting "semver vulnerable to Regular Expression Denial of Service" as a moderate security issue that is present in semver < v7.5.2 and fixed in semver v7.5.2

When I try to fix this, I can only get semver up to version 5.7.1 because of dependencies of @wordpress/scripts

The chain of dependencies seems to be:

• @wordpress/[email protected] requires npm-package-json-lint: ^5.0.0
• [email protected] requires meow: ^6.1.1
• [email protected] requires normalize-package-data: ^2.5.0
• [email protected] requires semver: 2 || 3 || 4 || 5

Updating npm-package-json-lint to v6.4.0 would fix this:

• [email protected] requires meow: ^9.0.0
• [email protected] requires normalize-package-data: ^3.0.0
• [email protected] requires semver: ^7.3.4

I'd love to try to make a PR for this, but don't know how to do this given the mono-repo nature here.

Are there plans to update this dependency? Can someone that has the repo set up try it and see if it's a breaking change?

Thanks

[rosswintle]

Just an update on this...

I dived into the semver repos and followed some other dependency trails.

babel depends on semver v6.x and they have reasons not to update to semver version 7+.

They have said:

We are waiting for a backport fix to semver v6. If the fix is not available within this week, we will fork semver v6 with the proper fix.

There is an issue where this is being discussed on the semver repo.

The maintainers there have said:

At this time, seeing as how v5/6 is a single 1400+ line file with outdated testing deps and no working CI we do not have plans to backport this.

But then people have been submitting PRs updating all the CI, tests and stuff as well as patching the older versions.

So this could all be fixed in a few days time.

It still seems to me like @wordpress/scripts should update its dependencies though, if this is backwards compatible. npm-package-json-lint v5.4.2 is over 18 months old now.

[gziolo]

It still seems to me like @wordpress/scripts should update its dependencies though, if this is backwards compatible. npm-package-json-lint v5.4.2 is over 18 months old now.

It would be great to update npm-package-json-lint to a more recent version. I see that v7.0.0 dropped support for Node 14 so we would need to update to Node 16/18 in Gutenberg first. Therefore, we could go with v6.4.0 for the time being. Would it help?

[rosswintle]

I've not checked, but yes. Any dependency updates here are good.

I think everything got updated/patched upstream now anyway, but would still be better to get an update.

[gziolo]

I opened #53636 which should fix the issue.