Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing a page in the Site Editor: Content panel should only include canonical blocks #52337

Closed
jameskoster opened this issue Jul 5, 2023 · 2 comments · Fixed by #52351
Closed
Assignees
Labels
[Feature] Page Content Focus Ability to toggle between focusing on editing the page and editing the template in the site editor. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended

Comments

@jameskoster
Copy link
Contributor

If you edit a page in the Site Editor, the Inspector includes shortcuts to select blocks pertaining to page content, e.g. Title, Post Content, Post Featured Image:

Screenshot 2023-07-05 at 16 05 35

Currently there doesn't seem to be any logic around how to handle instances of these blocks that do not pertain to the selected page. For example, you will find duplicate blocks listed if:

  1. The page itself contains a custom Query Loop
  2. The template that displays the page contains a custom Query Loop
Screenshot 2023-07-05 at 16 05 00

This somewhat undermines the usefulness of the Content panel, and makes it feel a bit buggy. Ideally only the canonical versions of these blocks should be surfaced in this UI.

cc @SaxonF @noisysocks

@jameskoster jameskoster added [Type] Bug An existing feature does not function as intended [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Jul 5, 2023
@SaxonF
Copy link
Contributor

SaxonF commented Jul 5, 2023

I was trying to work out how to reproduce this issue. Query loop makes a lot of sense. Thank you !

@noisysocks
Copy link
Member

Aha 🙂 good catch.

@noisysocks noisysocks added the [Feature] Page Content Focus Ability to toggle between focusing on editing the page and editing the template in the site editor. label Jul 5, 2023
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jul 6, 2023
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Page Content Focus Ability to toggle between focusing on editing the page and editing the template in the site editor. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants