Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental Page List: Ensure sorting by doesn't cover up other drop downs #55169

Open
annezazu opened this issue Oct 9, 2023 · 3 comments
Open
Labels
[Feature] Data Views Work surrounding upgrading and evolving views in the site editor and beyond [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

annezazu commented Oct 9, 2023

Took #54966 for a quick spin and I know it's a work in progress but wanted to note for @ntsekouras as follow up to ensure the sorting drop down doesn't cover up the other drop downs. Right now, it feels a bit cluttered to have the two overlap.

A screenshot:

Screenshot 2023-10-09 at 11 44 32 AM

Video for clarity:

sorting.mov
@annezazu annezazu added [Type] Enhancement A suggestion for improvement. [Feature] Data Views Work surrounding upgrading and evolving views in the site editor and beyond labels Oct 9, 2023
@ntsekouras
Copy link
Contributor

I had commented about that and pinged folks that work on components. This might be hard to change and we might need to consider some different design. See @ciampo's reply:

This works but I couldn't make it to match the design to open a third nested submenu on the left. I've checked radix docs about it a bit, but couldn't fix it. --cc @ciampo .

I don't think that's really possible, because I believe that nested menu always open to the right (in LTR environments), and only open to the left when there isn't space available on the right. So in this case, the third nested submenu has the space to open to the right and it does so. My hunch is that this behaviour can't be changed

Also, a heads-up that the experimental DropdownMenuV2 likely won't stick around too much in its currently iterations (see #50459)

@ciampo
Copy link
Contributor

ciampo commented Oct 10, 2023

Let's put this on ice for the time being, until the new dropdownmenu component is ready to be used. I may be able to expose a way to change where the submenu opens in the new implementation

@ciampo ciampo mentioned this issue Oct 10, 2023
53 tasks
@annezazu
Copy link
Contributor Author

Great! Thank you all for chiming in and for the broader context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Data Views Work surrounding upgrading and evolving views in the site editor and beyond [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants