Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataViews: Frame title should match current view #56199

Open
Tracked by #55083
jameskoster opened this issue Nov 16, 2023 · 4 comments · Fixed by #59011 · May be fixed by #61983
Open
Tracked by #55083

DataViews: Frame title should match current view #56199

jameskoster opened this issue Nov 16, 2023 · 4 comments · Fixed by #59011 · May be fixed by #61983
Labels
[Feature] Data Views Work surrounding upgrading and evolving views in the site editor and beyond Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

For instance in this view:

Screenshot 2023-11-16 at 10 22 04

The frame title should be "Drafts" instead of "Pages":

Screenshot 2023-11-16 at 10 23 09
@jameskoster jameskoster added [Type] Enhancement A suggestion for improvement. [Feature] Data Views Work surrounding upgrading and evolving views in the site editor and beyond labels Nov 16, 2023
@oandregal
Copy link
Member

I actually have a PR to remove it at #56241 :)

Related thread #56157 (comment)

I think we could do with actually removing the page title, I've prepared a PR before seeing this one #56241 The title seems to me a bit redundant with the sidebar info (hierarchy/status: "Pages in draft").

@jameskoster
Copy link
Contributor Author

Reopening. This one is about the title of the white content area, #59011 was about the sidebar titles.

@jameskoster jameskoster reopened this Feb 27, 2024
@oandregal oandregal changed the title Data views: Frame title should match current view DataViews: Frame title should match current view Mar 12, 2024
@jameskoster jameskoster removed their assignment May 8, 2024
@jameskoster jameskoster added the Needs Dev Ready for, and needs developer efforts label May 20, 2024
@jameskoster
Copy link
Contributor Author

Another reason to close this one; Pages and Templates data views are currently inconsistent with Patterns. As you navigate through Pattern categories the frame header updates accordingly, unlike Page and Templates.

@Souptik2001
Copy link

Souptik2001 commented May 25, 2024

Hi @jameskoster ,

I have raised a PR for this considering the comment you mentioned over here -#56241 (comment).

So, can you please review the PR at your convenience.

Not related to the above PR, but just adding a personal observation over here -

Please ignore! I found this issue - #60468 This one states exactly the same thing. 😅

As you can see in the below video, when I change the view to suppose Draft and then clear out the Draft filter, still the active view remains as Draft. Because of this the left sidebar and also the subtitle I added remains unchanged.

Thinking about this I think this is what is expected, that's because the views are meant to be kind of preset filters. So, anyone can select a preset filter and then edit the filters, but still ultimately we are in that preset filter only. So, yeah it makes sense. But just wanted to put this here.

Screen.Recording.2024-05-25.at.7.37.04.PM.mov

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Data Views Work surrounding upgrading and evolving views in the site editor and beyond Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
Status: Needs Dev
Status: 🏈 Punted to 6.7
4 participants