Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataviews: Make preview part of title field display in Table layout #56976

Closed
jameskoster opened this issue Dec 12, 2023 · 2 comments
Closed
Labels
[Feature] Data Views Work surrounding upgrading and evolving views in the site editor and beyond [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

Preview / Featured image is currently given it's own column/cell in table layout:

Screenshot 2023-12-12 at 11 38 41

This creates an unnecessarily large gap between the preview and the title. It would be good to try making the preview display a part of the title field:

Screenshot 2023-12-12 at 11 40 16
@jameskoster jameskoster added [Type] Enhancement A suggestion for improvement. [Feature] Data Views Work surrounding upgrading and evolving views in the site editor and beyond labels Dec 12, 2023
@oandregal
Copy link
Member

For table, we don't declare what's the "media field". So far, we haven't given it special treatment, so we didn't need to.

One way to implement this issue would be to:

  • set the "featured image" as the media field for the table layout (it's already declared as such for the other layouts)
  • render the media field next to the primary field
  • do not render a separate column for the media field

@jameskoster
Copy link
Contributor Author

Closing in favor of #58012

@jameskoster jameskoster closed this as not planned Won't fix, can't repro, duplicate, stale Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Data Views Work surrounding upgrading and evolving views in the site editor and beyond [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants