Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Hub: Make the View Site link always visible #57421

Closed
afercia opened this issue Dec 28, 2023 · 2 comments · Fixed by #57423
Closed

Site Hub: Make the View Site link always visible #57421

afercia opened this issue Dec 28, 2023 · 2 comments · Fixed by #57423
Assignees
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback. [Package] Edit Site /packages/edit-site [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Dec 28, 2023

Description

In the Site Editor, at the top of the navigation panel, the 'site hub' shows a View Site link only when the site hub itself is hovered or the link is focused. Screenshot:

Screenshot 2023-12-28 at 10 32 29

While I do realize the intent to make the site hub 'cleaner', I'm not sure hiding an important functionality is ideal. To me, the only effect is that this link is less discoverable.

  • If this link is important enough, it should always be visible. If it's not important, it should be removed.
  • 'cleanliness' of the UI is a subjective perception that should never have priority on functionality.
  • On mobile there is no hover state, and users rarely use keyboards connected to a mobile device so this link is basically not available to mobile devices.
  • It's (almost?) a unique case in the whole editor UI where an interactive control is only revealed on hover / focus. As such, it's inconsistent and provides an unexpected interaction.

Step-by-step reproduction instructions

  • Go to the Site Editor.
  • Hover your pointing device on the top part of the navigation panel.
  • Observe the View Site link becomes visible.
  • Move your pointing device away from the top part of the navigation panel.
  • Observe the View Site link is now hidden.
  • Use the keyboard to navigate the UI by pressing the Tab key.
  • Observe the View Site link becomes visible on focus.
  • Tab away from the View Site link.
  • Observe the View Site link is now hidden.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@afercia afercia added [Type] Bug An existing feature does not function as intended [Package] Edit Site /packages/edit-site [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). labels Dec 28, 2023
@afercia
Copy link
Contributor Author

afercia commented Dec 28, 2023

Adding the accessibility label, as the cognitive load an unexpected interaction are an accessibility issue IMHO.

@afercia afercia added the Needs Design Feedback Needs general design feedback. label Dec 28, 2023
@afercia afercia self-assigned this Dec 28, 2023
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Dec 28, 2023
@carolinan
Copy link
Contributor

I agree with this assessment.
There are additional comments from members of the accessibility team on the original pull request:
#50420 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback. [Package] Edit Site /packages/edit-site [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants