Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My Patterns: the pagination doesn't keep the state after click on a pattern #59003

Open
miksansegundo opened this issue Feb 14, 2024 · 5 comments
Labels
[Feature] Data Views Work surrounding upgrading and evolving views in the site editor and beyond [Type] Bug An existing feature does not function as intended

Comments

@miksansegundo
Copy link
Contributor

Description

The pagination doesn't keep the state in My Patterns page.

I expected that after I use the pagination to see a page, I can click on a pattern, to preview it and then click the < back button on the sidebar of the pattern detail to come back to the same page.

Step-by-step reproduction instructions

  • Go to My patterns in the Site Editor
  • Use the navigation to see another page
  • Click on a pattern
  • Click on the < back button on the pattern detail page
  • Verify the pagination is reset and you see the first page

Screenshots, screen recording, code snippet

Screen.Capture.on.2567-02-14.at.16-56-52.mp4

Environment info

Gutenberg: v17.7.0-rc.1

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@miksansegundo miksansegundo added the [Type] Bug An existing feature does not function as intended label Feb 14, 2024
@miksansegundo
Copy link
Contributor Author

This same issue affects any Data View options and filters.

I expected those to be also kept when I preview, or even edit a pattern, and I go back to the My patterns via the < back button.

Filters View Options
Screenshot 2567-02-14 at 17 24 13 Screenshot 2567-02-14 at 17 18 36

@richtabor richtabor added the [Feature] Data Views Work surrounding upgrading and evolving views in the site editor and beyond label Feb 14, 2024
@annezazu
Copy link
Contributor

cc @ntsekouras

@ntsekouras
Copy link
Contributor

Yeah, right now that's not possible. There are some discussions about adding some of the params in the URL that would resolve this. We do this for the layout type right now only(grid, table, etc..). There are some nuances with the custom views exploration that could come from database for example and in that case we have two sources of truth, but will probably prioritize the url query params.

@colorful-tones
Copy link
Member

will probably prioritize the url query params.

This sounds like a good plan. We’ll need URL query params soon. 👍

@annezazu
Copy link
Contributor

Removing this from the 6.5 board since there's not an immediate solution to implement as shown above and due to the voting that happened in the async triage session this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Data Views Work surrounding upgrading and evolving views in the site editor and beyond [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

5 participants