Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation .pot build replaces '/' with '\' in Windows. #597

Closed
BE-Webdesign opened this issue May 2, 2017 · 3 comments
Closed

Translation .pot build replaces '/' with '\' in Windows. #597

BE-Webdesign opened this issue May 2, 2017 · 3 comments
Assignees
@aduth
Labels
[Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Build Tooling Issues or PRs related to build tooling

Comments

@BE-Webdesign
Copy link
Contributor

BE-Webdesign commented May 2, 2017 •
edited
Loading

The dreaded Windows slash debacle appears to be present in the translation build. Yes, I am one of those terrible Windows users 😲. I am not familiar with how the build works, otherwise I would be glad to patch. When the .pot file is built instead of:

blocks/components/editable/index.js:38

You get:

blocks\components\editable\index.js:38

Currently in all of my PRs I don't stage the .pot file for commit and hopefully the changes get put in on someone else's PR. Most likely node's resolve() is changing the resolve to match Windows' paths since I am on Windows?
@BE-Webdesign BE-Webdesign added the [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later label May 2, 2017
@BE-Webdesign BE-Webdesign mentioned this issue May 2, 2017
Merged
@BE-Webdesign
Copy link
Contributor Author

It appears there is a babel plugin that handles everything so I assume changing something in there will solve our problems.

@aduth aduth self-assigned this May 2, 2017
@aduth aduth added the [Type] Build Tooling Issues or PRs related to build tooling label May 2, 2017
@aduth
Copy link
Member

aduth commented May 2, 2017

Thanks for noting this. I'll plan to take a look.

@BE-Webdesign
Copy link
Contributor Author

Ping me in slack, if you need testing, unless you have a VM for Windows.

@aduth aduth mentioned this issue May 3, 2017
Merged
@aduth aduth closed this as completed in #622 May 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aduth aduth

Labels
[Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aduth @BE-Webdesign