Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression with mobile formatting toolbar #6236

Closed
jasmussen opened this issue Apr 18, 2018 · 1 comment
Closed

Regression with mobile formatting toolbar #6236

jasmussen opened this issue Apr 18, 2018 · 1 comment
Assignees
Labels
Mobile Web Viewport sizes for mobile and tablet devices [Type] Bug An existing feature does not function as intended

Comments

@jasmussen
Copy link
Contributor

Some time in the most recent releases, the mobile block-toolbar regressed. The intended behavior is that it works the same as "Fix toolbar to top", but always enabled on mobile. Here's the behavior of master:

mobile-toolbar

As such, the bug is that we need to enable, no matter any previous setting, fix toolbar to top on mobile always.

This would also fix a secondary issue, as you can see, where the iPhone selection popup toolbar covers the block toolbar.

Another issue is that we should probably never enable isEditing mode on mobile, the primary reason being that if we do, it's hard to get back the movers, trash and ellipsis, because it's not enough to just tap on the text to get the block UI to show, you have to select a different block first.

@jasmussen jasmussen added [Type] Bug An existing feature does not function as intended Mobile Web Viewport sizes for mobile and tablet devices labels Apr 18, 2018
@youknowriad youknowriad self-assigned this Apr 20, 2018
@jasmussen
Copy link
Contributor Author

This is fixed in 2.9 as of #6347

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile Web Viewport sizes for mobile and tablet devices [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants