-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilize Typography Block Supports Keys for WP 6.7 #63001
Comments
@scruffian I am unsure of if writingMode should be stabilized without the text orientation changes? (#60030) |
I agree |
Oh, thanks for flagging! I'm working on a draft PR over in #63401 — I'll omit |
This is a fantastic initiative @andrewserong . While we are at it, can we also tackle |
Thanks @ndiego, if you wouldn't mind opening an issue for those, that'd be great! My main focus right now is on the Typography support and this initial stage, so that we can contain the scope of the changes we're rolling out. But my hope is that with #63401 it should make subsequent stabilization a bit easier 🙂 |
Part of:
This issues tracks progress towards stabilizing the typography block support. Note that in order to provide backwards compatibility for block plugins out in the wild, fallback support for the existing
__experimental
prefixes should be provided.Stabilize the following typography block supports:
__experimentalFontFamily
→fontFamily
__experimentalTextDecoration
→textDecoration
__experimentalFontStyle
→fontStyle
__experimentalFontWeight
→fontWeight
__experimentalLetterSpacing
→letterSpacing
__experimentalTextTransform
→textTransform
__experimentalWritingMode
→writingMode
Tasks
lib/block-supports/typography.php
to use the non__experimental
prefix, falling back to the__experimental
prefix if available.__experimental
prefix, falling back to the__experimental
prefix if available.block.json
schema to support the non__experimental
prefix, with a note that it is only as of WP 6.7+block.json
files to use the non__experimental
prefixesblock.json
schema to remove the__experimental
prefix. Note that the code in WordPress should still support the__experimental
prefix, but at this stage, the experimental prefix will be treated as deprecated.In my opinion, in order to provide the widest possible support for block plugins, I think it could be valuable to provide fallback support for the
__experimental
in the long-term. In other words, when implementing the fallback ideas above, let's do so in a way that's easy to maintain.The text was updated successfully, but these errors were encountered: