Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No background image alignment options for Cover Image block #6602

Closed
ZebulanStanphill opened this issue May 5, 2018 · 3 comments
Closed

Comments

@ZebulanStanphill
Copy link
Member

Issue Overview

If you use a wide image for the Cover Image block, the image will extend past the right edge of the block, and the image will not be centered. Ideally, you should be able to control at least the horizontal alignment of the image, and preferably also the vertical alignment.

Steps to Reproduce

  1. Insert a Cover Image block.
  2. Choose an image with a wide aspect ratio.
  3. Notice that the image extends past the right edge of the block and is not centered.

Tested in Firefox Nightly 61.

Expected Behavior

By default, the image should be vertically and horizontally centered. There should also be options in the block inspector to change the alignment of the image.

Current Behavior

The default alignment of the image is such that wide images are not horizontally centered, and tall images are not vertically centered.

@karmatosed
Copy link
Member

This came up a little while ago here: #5458.

This was decided to move to Customization as a phase two option. As a result lets merge this into that issue and close here. Saying it's to be done in phase two isn't saying it won't, it's actually saying it will but not right now. Thanks for suggesting something that is very much desirable going forward.

@ZebulanStanphill
Copy link
Member Author

@karmatosed The default horizontal alignment for the Cover Image background should still be centered, though, should it not? The current left-aligned default does not really make sense to me.

@ZebulanStanphill
Copy link
Member Author

Looks like the default horizontal alignment issue is covered by #6066 and #6760. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants