Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocks: Image and Gallery blocks depend on deprecated RichText events #6944

Closed
aduth opened this issue May 24, 2018 · 0 comments
Closed

Blocks: Image and Gallery blocks depend on deprecated RichText events #6944

aduth opened this issue May 24, 2018 · 0 comments
Assignees
@gziolo
Labels
[Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended
Milestone
3.0

Comments

@aduth
Copy link
Member

aduth commented May 24, 2018

Related: #6286
Proposed fix: #6871

Note: There's already a proposed fix in #6871, but marking this as a bug which ought to be resolved before a 3.0 release where the deprecated functionality is slated to be removed.

The changes in #6286 cause TinyMCE event forwarding to be deprecated. However, some core blocks (namely, Image and Gallery) depend on the onFocus event which is no longer explicitly called by the RichText component.

We should either:

  • Restore onFocus handling to RichText
  • Refactor Image and Gallery blocks to avoid relying on onFocus

Additionally, we should audit other blocks which may depend on this or other events no longer passed.
@aduth aduth added the [Type] Bug An existing feature does not function as intended label May 24, 2018
@aduth aduth added this to the 3.0 milestone May 24, 2018
@gziolo gziolo self-assigned this May 27, 2018
@aduth aduth added the [Priority] High Used to indicate top priority items that need quick attention label May 30, 2018
@aduth aduth mentioned this issue May 30, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gziolo gziolo

Labels
[Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
2 participants
@gziolo @aduth