Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Block (+) is inconsistently used, possibly confusing #8363

Closed
mintplugins opened this issue Aug 1, 2018 · 10 comments
Closed

Add Block (+) is inconsistently used, possibly confusing #8363

mintplugins opened this issue Aug 1, 2018 · 10 comments
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed [Type] Enhancement A suggestion for improvement.

Comments

@mintplugins
Copy link

mintplugins commented Aug 1, 2018

I believe the "Add Block (+)" text and icons are inconsistently used, and this experience could be improved to prevent user frustration and confusion.

Places this is used:

  1. At the top, clicking it will add a new block to the page. All is well here.

screen shot 2018-08-01 at 10 53 50 am

  1. Between blocks, clicking it will add a new block to the page. All is well here as well.

screen shot 2018-08-01 at 10 54 54 am

  1. However, once you have added a new block, you see the Add Block (+) on the left, but clicking it does not add a new block to the page. Instead, clicking it allows you to choose the block type.

screen-shot-2018-08-01-at-10 58 26-am

Proposal:
For the Add Block (+) on the left side, the wording should change from "Add Block" to "Select Block Type", and the icon should be the default block type's icon. I believe the default block type is a paragraph, so perhaps it should use that as the icon. If not that, perhaps a new icon should be introduced which is consistently used when prompting the user to choose a block type.

@ZebulanStanphill
Copy link
Member

I think this is a duplicate of either #5054 or #7271. Or maybe both, and those two are duplicates of each other.

@mintplugins
Copy link
Author

mintplugins commented Aug 1, 2018

@SuperGeniusZeb Thanks for the link. I would say that while similar, this issue is unique in that it focuses on the fact that the text/icon is incorrect, which is possibly a smaller/simpler scope.

@designsimply designsimply added [Type] Enhancement A suggestion for improvement. [Feature] Inserter The main way to insert blocks using the + button in the editing interface [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed labels Aug 1, 2018
@designsimply
Copy link
Member

I think of it as there is an unassigned space for a block and the (+) in that context adds a block. In terms of design, consistency for this label feels helpful to me. I think changing the wording could introduce more confusion for others. There are also translation implications to changing the wording to something longer. It's very possible there could be split opinions about this where some people prefer it one way while others prefer it as is. It is also worth noting that the current design is the result of a lot of user testing and lots of different variations were tried.

@mintplugins
Copy link
Author

@designsimply I don't want to seem disrespectful, but I completely disagree.

As I outlined in my screenshot, this button doesn't add a block, the block is already there. Therefore, it is incorrectly labelled.

Would you be able to elaborate on why you think labelling it accurately, based on what it does, would cause confusion for others?

There definitely will be split opinions about what to call it, but that's not a good reason to label it incorrectly, nor to use the wrong icon.

I think the number of issues relating to this exact thing show that it is confusing, and I believe all could be solved by calling it what it is.

As a new user to Gutenberg, this is probably the most confusing part of it for me.

Again, please don't take any of my disagreement personally or as disrespect. I just feel strongly that this is extremely poor/confusing UX, and I don't think it's something that should be glossed-over.

@designsimply
Copy link
Member

Would you be able to elaborate on why you think labelling it accurately, based on what it does, would cause confusion for others?

Sure! First, I think labeling it accurately is a good idea. Where we differ in opinion (and that's okay!) is that I think the UI you are referring to is not a block until a block type is added.

Thanks for talking out the issue with me. It's certainly not being glossed over and I'm sorry if you felt that impression earlier.

@ZebulanStanphill
Copy link
Member

@designsimply

Where we differ in opinion (and that's okay!) is that I think the UI you are referring to is not a block until a block type is added.

From a technical standpoint, it is a block. An empty Paragraph, to be specific. It says Paragraph in the block inspector, and the ellipsis menu even appears for it.

image

@mintplugins
Copy link
Author

mintplugins commented Aug 2, 2018

@designsimply Thanks for engaging with us on this!

As @SuperGeniusZeb mentioned, it is a block, and it is actually there already. If you update the editor, that empty block actually shows on the frontend. It outputs empty <p> tags, and it remains in the gutenberg editor as well when refreshing.

That block is there. I can understand that from your point of view, clicking the (+) on the left is adding a block, but that's not what is actually happening. The block is actually already there, and even creates a badly laid out DOM on the frontend, with empty <p> tags not being used for anything.

If this were properly labelled, it would make it obvious that the block actually is there, and people could remove it to make sure their layouts aren't wonky. I believe it would also completely alleviate the confusion many people are having about the inconsistency of it showing up sometimes, and sometimes not.

If we let people know that the block is actually there (because it actually is), they will have a more complete understanding of what is happening, and we'll be equipping them to build better layouts with less confusion.

@mintplugins
Copy link
Author

To help demonstrate that the blocks are indeed actually there, I added 9 empty blocks to the editor.
Sure enough, it output 9 empty <p> tags on the frontend.

See screenshots:

Gutenberg:
screen shot 2018-08-02 at 12 01 19 pm

Frontend:
screen shot 2018-08-02 at 12 01 46 pm

The blocks are not just placeholders. They are actually on the page, and it creates poor/unneccesary output.

@nerrad
Copy link
Contributor

nerrad commented Jun 1, 2019

There have been some changes since this issue was first created but I think it's still a valid issue. For consistency with elsewhere in the ui, I wonder if the left button being referenced here could be switched to the same ui indicator as the "Transform To" icon button:

screenshot

If behaviour was similar to the transform button (i.e. shows what block type is set currently for that block and on hover changes to the "Transform To:" action) that would be consistent.

@designsimply designsimply added the Needs Decision Needs a decision to be actionable or relevant label Jun 4, 2019
@mtias mtias removed the Needs Decision Needs a decision to be actionable or relevant label Nov 17, 2019
@mtias
Copy link
Member

mtias commented Aug 30, 2020

There's been several iteration to all the inserters and some further improvements tracked in #21080. Closing this for now but feel free to open new issues if there's further feedback.

@mtias mtias closed this as completed Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

5 participants