Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve consistency of empty states for media blocks #8409

Closed
sarahmonster opened this issue Aug 2, 2018 · 6 comments · Fixed by #16135
Closed

Improve consistency of empty states for media blocks #8409

sarahmonster opened this issue Aug 2, 2018 · 6 comments · Fixed by #16135
Labels
[Block] Image Affects the Image Block [Block] Video Affects the Video Block [Feature] Blocks Overall functionality of blocks Needs Copy Review Needs review of user-facing copy (language, phrasing)

Comments

@sarahmonster
Copy link
Member

sarahmonster commented Aug 2, 2018

For the most part, the media blocks use pretty consistent empty states, but there are a few areas where they could be fine-tuned.

Image

screenshot 2018-07-30 13 54 15

Cover image

screen shot 2018-07-25 at 9 35 29 am

Gallery

screen shot 2018-07-30 at 2 38 31 pm

Video

screenshot 2018-07-30 15 30 20

Audio

screenshot 2018-07-30 15 04 45

File

screenshot 2018-07-30 14 30 41

Suggestions

  1. The "Use URL" option is great. Can we use it for all media blocks?

  2. The copy is a bit jargony—not everyone understands URL. Can we make this a bit friendlier? Additionally, are there accessibility concerns with using a placeholder instead of a label here? Something along these lines, perhaps:

screenshot 2018-08-03 00 25 11

  1. "Upload" is very desktop-centric. Could we use "add" instead?

  2. Can we improve the format of this sentence, used across all blocks here? "Drag an audio, upload a new one or select a file from your library." There are actually four options for [most] blocks: link, upload, drag, and select from library, but the first three are more or less the same effect. Perhaps instead "Add a new [whatever] file or select a file from your library."?

@sarahmonster sarahmonster added [Feature] Blocks Overall functionality of blocks Needs Copy Review Needs review of user-facing copy (language, phrasing) labels Aug 2, 2018
@sarahmonster sarahmonster changed the title Improve consistency of placeholders for media blocks Improve consistency of empty states for media blocks Aug 2, 2018
@sarahmonster sarahmonster mentioned this issue Aug 2, 2018
11 tasks
@kjellr kjellr mentioned this issue Aug 2, 2018
12 tasks
@michelleweber
Copy link

+1 for changing "Drag an audio, upload a new one or select a file from your library." I'd still specify all the options, though to be super clear. I'm thinking something like:

Add a new file to your media library -- you can drag and drop it here, or click "Add" to select one -- or choose a file you've already added.

Add a new file to your media library -- you can drag and drop it here, or click "Add" to select one -- choose a file you've already added, or insert a link to the file.

On the "upload" point -- am I not still uploading a file to my site when I add it via the app? It wouldn't occur to me that this work is desktop-specific, so I would love to understand more. And does the "drag a file" instruction have the same problem re: desktop-centricness? Does mobile actually need a whole other set of copy?

@kjellr
Copy link
Contributor

kjellr commented Aug 3, 2018

Add a new file to your media library -- you can drag and drop it here, or click "Add" to select one -- or choose a file you've already added.

This is getting a little too long for my taste, and it's missing the URL option... I wonder if we can keep it light, and let the buttons/fields speak for themselves?

artboard

On the "upload" point -- am I not still uploading a file to my site when I add it via the app? It wouldn't occur to me that this work is desktop-specific, so I would love to understand more.

Yeah, I think upload is fine here. Even on mobile, you're uploading.

does the "drag a file" instruction have the same problem re: desktop-centricness? Does mobile actually need a whole other set of copy?

This does feel a little desktop-centric. Swapping out the copy on mobile might be a good route to take.

@michelleweber
Copy link

It looked like some blocks include the URL and some don't, so there are two versions. That said, yeah, it is longer. We can go with Sarah's "Add a new X file here, or pick one from your media library."

@kjellr
Copy link
Contributor

kjellr commented Aug 3, 2018

It looked like some blocks include the URL and some don't, so there are two versions.

Ah, sorry — I somehow missed that second version.

We can go with Sarah's "Add a new X file here, or pick one from your media library."

Sounds good to me. 👍

@sarahmonster sarahmonster added the [Block] Image Affects the Image Block label Oct 25, 2018
@sarahmonster sarahmonster added the [Block] Video Affects the Video Block label Nov 2, 2018
@kjellr
Copy link
Contributor

kjellr commented Jun 12, 2019

Hey folks! Just want to confirm the phrasing here. Most of these have URL options, and I think it's getting little wordy:

gutenberg test_wp-admin_post php_post=1 action=edit (1)

cc @michelleweber

@michelleweber
Copy link

I'd delete the "here" to save a few characters. Seeing it now, it's not needed. "Pick one from your media library" could also be "browse your media library."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Image Affects the Image Block [Block] Video Affects the Video Block [Feature] Blocks Overall functionality of blocks Needs Copy Review Needs review of user-facing copy (language, phrasing)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants