Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subheading block: text lacks sufficient contrast #8716

Closed
sarahmonster opened this issue Aug 8, 2018 · 2 comments
Closed

Subheading block: text lacks sufficient contrast #8716

sarahmonster opened this issue Aug 8, 2018 · 2 comments
Labels
[Feature] Blocks Overall functionality of blocks [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Enhancement A suggestion for improvement.

Comments

@sarahmonster
Copy link
Member

The subheading block uses a light grey for the text, which lacks sufficient contrast against the white background:

screenshot 2018-08-08 15 05 29

The color combination #9199a1/#ffffff has a contrast ratio of 2.89, which is not sufficient. At this size, you will need a ratio of at least 4.5.

For better legibility, this should probably be increased.
@sarahmonster sarahmonster added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Feature] Blocks Overall functionality of blocks labels Aug 8, 2018
@sarahmonster sarahmonster mentioned this issue Aug 8, 2018
Closed
10 tasks
@designsimply designsimply added the [Type] Enhancement A suggestion for improvement. label Aug 8, 2018
@abrightclearweb
Copy link

Agreed on this. Does Subheading have a semantic meaning to assistive technologies?

It is marked up as <p class="wp-block-subhead">Subheading</p> so I'm guessing not.

@tofumatt tofumatt mentioned this issue Aug 24, 2018
Closed
This was referenced Aug 25, 2018
Closed
Merged
@youknowriad
Copy link
Contributor

Subheading block is deprecated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Blocks Overall functionality of blocks [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@youknowriad @sarahmonster @designsimply @abrightclearweb