Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot insert block between selected block and previous block #8878

Closed
markjaquith opened this issue Aug 11, 2018 · 4 comments
Closed

Cannot insert block between selected block and previous block #8878

markjaquith opened this issue Aug 11, 2018 · 4 comments
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface

Comments

@markjaquith
Copy link
Member

Describe the bug
When a block is selected, you cannot insert a block between the selected block and the previous block (you can insert one below the selected block).

Seems like a more general version of #8632.

To Reproduce

  1. Add 3 Paragraphs.
  2. Select the third paragraph.
  3. Hover mouse between second and third paragraphs. No in-between inserter.
  4. Select the second paragraph.
  5. Hover mouse between first and second paragraphs. No in-between inserter.

Expected behavior
You can still in-between insert above the selected block.

Screenshots
screen shot 2018-08-11 at 3 33 37 pm

Desktop (please complete the following information):

  • OS: macOS
  • Browser: Firefox
  • Version 61.0.1

Additional context
Running Gutenberg @ b5490a6e2d917cf911f67bee0e7f98350a17a08e and toolbar is NOT pinned to the top.

@chrisvanpatten
Copy link
Member

This was an intentional decision in #7168 / #7220 because the sibling inserter could get hidden below the toolbar. Admittedly it's not a perfect solution, but #7297 will add additional insertion options to the block settings menu as well.

@chrisvanpatten chrisvanpatten added the [Feature] Inserter The main way to insert blocks using the + button in the editing interface label Aug 11, 2018
@ZebulanStanphill
Copy link
Member

Also note that the outcome of #6224 could result in a revised sibling inserter UI which could provide another solution to this issue.

@talldan
Copy link
Contributor

talldan commented Aug 14, 2018

@markjaquith I've got a PR open #8909 to add Insert Before and After options to the block settings menu (and keyboard shortcuts). Do you think that will resolve this issue? Let me know and I'll make sure this gets closed when that's merged.

@talldan
Copy link
Contributor

talldan commented Aug 15, 2018

#8909 now merged, so closing this.

@talldan talldan closed this as completed Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface
Projects
None yet
Development

No branches or pull requests

4 participants