Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid hardcoding WP Links inside Gutenberg #9637

Closed
youknowriad opened this issue Sep 5, 2018 · 5 comments
Closed

Avoid hardcoding WP Links inside Gutenberg #9637

youknowriad opened this issue Sep 5, 2018 · 5 comments
Labels
[Type] Code Quality Issues or PRs that relate to code quality [Type] Enhancement A suggestion for improvement.

Comments

@youknowriad
Copy link
Contributor

We use links to target WP Admin pages inside Gutenberg packages

  • revisions
  • Shared blocks management
  • ...

These links only work in WP context and the packages are meant to be context agnostic.
We need to find a way to add these links in an "augmented" manner. Keeping the packages WP links free.
@youknowriad youknowriad added [Type] Enhancement A suggestion for improvement. npm Packages Related to npm packages labels Sep 5, 2018
@youknowriad youknowriad mentioned this issue Sep 5, 2018
Merged
@youknowriad youknowriad mentioned this issue Sep 24, 2018
Closed
4 tasks
@youknowriad youknowriad added the [Type] Code Quality Issues or PRs that relate to code quality label Feb 8, 2019
@paaljoachim
Copy link
Contributor

Is this issue still relevant?

@youknowriad
Copy link
Contributor Author

yes :)

@paaljoachim
Copy link
Contributor

Alrighty. Let's keep it open..:)

@gziolo gziolo removed the npm Packages Related to npm packages label Feb 1, 2021
@ramonjd
Copy link
Member

ramonjd commented Apr 2, 2024

Possibly related:

Maybe the links could be generated in the WP backend and only display when they're accessible via editor settings in JS?

@youknowriad youknowriad closed this as not planned Won't fix, can't repro, duplicate, stale Jul 2, 2024
@youknowriad
Copy link
Contributor Author

I think for the block editor package and agnostic packages, there's no hard coded links anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Type] Code Quality Issues or PRs that relate to code quality [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@youknowriad @gziolo @paaljoachim @ramonjd