From 168fdba0d9295c4d59fd1b47683dfc7644005be7 Mon Sep 17 00:00:00 2001 From: Thorsten Frommen Date: Fri, 8 Feb 2019 06:46:33 +0100 Subject: [PATCH 1/2] Set correct loading state --- .../editor/src/components/post-taxonomies/flat-term-selector.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/editor/src/components/post-taxonomies/flat-term-selector.js b/packages/editor/src/components/post-taxonomies/flat-term-selector.js index 411890ae5d615..b1cdb679e1879 100644 --- a/packages/editor/src/components/post-taxonomies/flat-term-selector.js +++ b/packages/editor/src/components/post-taxonomies/flat-term-selector.js @@ -78,7 +78,7 @@ class FlatTermSelector extends Component { componentDidMount() { if ( ! isEmpty( this.props.terms ) ) { - this.setState( { loading: false } ); + this.setState( { loading: true } ); this.initRequest = this.fetchTerms( { include: this.props.terms.join( ',' ), per_page: -1, From 0e895c14b2f8f8b5f97407ae55b6a6996a1f9760 Mon Sep 17 00:00:00 2001 From: Thorsten Frommen Date: Wed, 13 Feb 2019 18:22:56 +0100 Subject: [PATCH 2/2] Set loading state in constructor --- .../src/components/post-taxonomies/flat-term-selector.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/editor/src/components/post-taxonomies/flat-term-selector.js b/packages/editor/src/components/post-taxonomies/flat-term-selector.js index b1cdb679e1879..233f07cc3e2aa 100644 --- a/packages/editor/src/components/post-taxonomies/flat-term-selector.js +++ b/packages/editor/src/components/post-taxonomies/flat-term-selector.js @@ -70,7 +70,7 @@ class FlatTermSelector extends Component { this.searchTerms = throttle( this.searchTerms.bind( this ), 500 ); this.findOrCreateTerm = this.findOrCreateTerm.bind( this ); this.state = { - loading: false, + loading: ! isEmpty( this.props.terms ), availableTerms: [], selectedTerms: [], }; @@ -78,7 +78,6 @@ class FlatTermSelector extends Component { componentDidMount() { if ( ! isEmpty( this.props.terms ) ) { - this.setState( { loading: true } ); this.initRequest = this.fetchTerms( { include: this.props.terms.join( ',' ), per_page: -1,