Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoices: Filling in the Address with a space causes an email without an attachment #255

Open
dd32 opened this issue Oct 30, 2019 · 0 comments
Assignees

Comments

@dd32
Copy link
Member

dd32 commented Oct 30, 2019

When using the Invoices plugin, if you fill in the Address field with a space (Indicating "I don't care about the address") it fails to generate an invoice.

The CPT is created as a draft and an email is sent with As requested during your purchase, please find attached an invoice for your tickets to "%s". but has no attachment.

What I expected:

  1. Checkout to fail requesting I fill in the required field (or JS trimming the fields client side before validation)
    or
  2. Invoice to be created without an Address (I don't see it as a required field, but I can see that it would be in some countries)
    or
  3. Email not to be sent (Forcing me to contact the Organisers for one)

I would err on the side of 1 if Camptix does client-side validation, or 2 otherwise.
3 should be implemented regardless, as it's pointless sending a invoice email if no invoice can be attached.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants