Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nit] Payment transaction docs: IssuedCurrencies in lower case #2772

Closed
ckeshava opened this issue Sep 18, 2024 · 1 comment
Closed

[Nit] Payment transaction docs: IssuedCurrencies in lower case #2772

ckeshava opened this issue Sep 18, 2024 · 1 comment

Comments

@ckeshava
Copy link

The documentation asks that Issued Currencies be specified in lower-case in the Amount, DeliverMax and the DeliverMin fields.

For non-XRP amounts, the nested field names are lower-case.

image

This does not appear to be true in practice. The responses of tx command pertaining to Payment transactions return upper-case Issued Currency representations: https://xrpl.org/resources/dev-tools/websocket-api-tool?server=wss%3A%2F%2Fxrplcluster.com%2F&req=%7B%22id%22%3A%22example_Payment%22%2C%22command%22%3A%22tx%22%2C%22transaction%22%3A%227BF105CFE4EFE78ADB63FE4E03A851440551FE189FD4B51CAAD9279C9F534F0E%22%2C%22binary%22%3Afalse%7D

I suspect we can submit upper-case IssuedCurrency representations in Payment transaction inputs too (I haven't been able to check it yet). Is the above statement true today?

@mDuo13
Copy link
Collaborator

mDuo13 commented Oct 15, 2024

This seems to be a misunderstanding.

The field names —specifically currency, issuer, and value—need to be lowercase. The field values don't need to be.

@mDuo13 mDuo13 closed this as completed Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants