-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QiskitDevice.probabilities() changed to QiskitDevice.probability() to… #80
Conversation
… restore compatibility with pennylane python package
Hi @rafaelha, thank you so much for your pull request! 🎊 Adjusting the name of the I'd be curious, was there perhaps a bug or any problems that you have faced while using |
Hi, yes, running a qnode on a qiskit device that returns |
I see that makes sense! Thank you so much once again for your addition! 😊 The tests are failing due to the test suite pulling the newest version ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much again for this change @rafaelha! 💯 😊
Opened two related pull requests:
- Qiskit v0.18 updates #81: includes changes due to the new version of Qiskit and allows passing the test suite on Travis
- IBMQ probs test #82: includes a test for the failing case that you have identified
Checked locally, the test from #82 picks up the case that was mentioned and the changes from this PR made it pass for me locally!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rafaelha! @antalszava, it looks like we are ready to merge in #80, #81, and #82. Do we want to update the changelog separately, since these three PRs are all somewhat related?
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
==========================================
- Coverage 99.12% 98.53% -0.59%
==========================================
Files 7 7
Lines 341 341
==========================================
- Hits 338 336 -2
- Misses 3 5 +2
Continue to review full report at Codecov.
|
Thanks for catching that @josh146! @rafaelha, could you please modify the
Thanks! 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rafaelha, updated changelog looks perfect!
… restore compatibility with pennylane python package