-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V0.19.1 updates #86
V0.19.1 updates #86
Conversation
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 261 261
=========================================
Hits 261 261 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @antalszava, nice that it wasn't too much work! Also, don't forget to update the changelog 😉
@@ -254,7 +254,7 @@ def test_extra_parameters_were_passed(self, recorder): | |||
with recorder: | |||
quantum_circuit(params={theta: 0.5, phi: 0.3}) | |||
|
|||
@pytest.mark.parametrize("qiskit_operation, pennylane_name", [(QuantumCircuit.crx, "CRX"), (QuantumCircuit.crz, "CRZ")]) | |||
@pytest.mark.parametrize("qiskit_operation, pennylane_name", [(QuantumCircuit.crx, "CRX"), (QuantumCircuit.crz, "CRZ"), (QuantumCircuit.cry, "CRY")]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!!
The updates with the new
0.19.1
Qiskit version:CRY
and testingCRY
with the other controlled rotationsQuantumCircuit.cnot
method toQuantumCircuit.cx