Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP Deprecated: Creation of dynamic property. PHP 8.2 #318

Open
YuraKril opened this issue Mar 1, 2023 · 5 comments
Open

PHP Deprecated: Creation of dynamic property. PHP 8.2 #318

YuraKril opened this issue Mar 1, 2023 · 5 comments
Assignees
@pumpkinball

Comments

@YuraKril
Copy link

YuraKril commented Mar 1, 2023

  • Version [e.g. 2.21.0]

Describe the bug
PHP Deprecated: Creation of dynamic property XeroAPI\XeroPHP\JWTClaims::$preferred_username is deprecated
@github-actions
Copy link

github-actions bot commented Mar 1, 2023

PETOSS-276

@github-actions
Copy link

github-actions bot commented Mar 1, 2023

Thanks for raising an issue, a ticket has been created to track your request

@YuraKril
Copy link
Author

Hello team. Any updates on the issue?

@pumpkinball pumpkinball self-assigned this Apr 5, 2023
@pumpkinball
Copy link
Contributor

Hi @YuraKril thanks for picking up this, and for submitting your PR.
I've changed it slightly so that the decodeIdToken function is setting $this->username.
Then the getPreferredUsername function will work in both scenarios.

@YuraKril
Copy link
Author

YuraKril commented Apr 7, 2023

Hi @pumpkinball .
When will these changes be available?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pumpkinball pumpkinball

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@YuraKril @pumpkinball