Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update commander to the latest version #100

Closed
XhmikosR opened this issue Oct 29, 2020 · 5 comments
Closed

Update commander to the latest version #100

XhmikosR opened this issue Oct 29, 2020 · 5 comments
Labels
dependencies Pull requests that update a dependency file enhancement help wanted

Comments

@XhmikosR
Copy link
Owner

And make use of variadic options
@XhmikosR XhmikosR added enhancement help wanted dependencies Pull requests that update a dependency file labels Oct 29, 2020
@XhmikosR XhmikosR mentioned this issue Jan 5, 2021
Closed
@XhmikosR XhmikosR mentioned this issue Feb 16, 2021
Closed
@danny007in
Copy link

what is variadic options
so i can solve

@XhmikosR
Copy link
Owner Author

tj/commander.js#1250

Also, this is a major version bump, I'm not sure if there any other breaking changes after 5.1.0 that affect us.

@danny007in
Copy link

in cleancss-cli they have migrated commander to v2 to v7.
so we do by checking there diff

@XhmikosR
Copy link
Owner Author

Each project is unique, so it's not the same procedure. And here, we don't really have CLI tests apart from a basic one.

@GeoSot GeoSot mentioned this issue Mar 8, 2021
Merged
@XhmikosR
Copy link
Owner Author

Fixed by #138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@XhmikosR @danny007in