Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2023.2] CONFIG_FILE and CONFIG_TMPL variables in makefile of examples #194

Open
brucebenedictus opened this issue Mar 7, 2024 · 1 comment

Comments

@brucebenedictus
Copy link

Hi,

I want to run the the HLS examples in the 2023.2 branch. The makefile in the examples use the environment variable CONFIG_FILE and CONFIG_TMPL.
My infrastructure uses these environment variables already.

Would it be possible not to check if the variables are already set?

@vermaete
Copy link

vermaete commented Mar 7, 2024

just to append to the issue of Bruce

The issue here is that gitlab-ci is using the CONFIG_FILE variable too.
https://docs.gitlab.com/runner/commands/#configuration-file
And probably many others.

Putting a kind of namespacing to the global Vitis variables (e.g. 'xlnx_' or 'vitis_') could solve this.

br

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants