Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check that finite length fields in buffer descriptors are validated for each tile type. #1097

Open
SamuelBayliss opened this issue Mar 6, 2024 · 1 comment
Open

Check that finite length fields in buffer descriptors are validated for each tile type. #1097

SamuelBayliss opened this issue Mar 6, 2024 · 1 comment
Assignees
@jgmelber
Labels
good first issue Good for newcomers quality Improve code quality: maintainability, cleanup, code reorganization.

Comments

@SamuelBayliss
Copy link
Collaborator

Shim DMA, Mem DMA and Tile DMA descriptors have fields with different lengths.

e.g. the buffer_length field is 32-bits in AIE2 for shim tiles, 17-bits for mem tiles and 14-bits for compute tiles.
@SamuelBayliss
Copy link
Collaborator Author

Nivedh ran into issues based on line 1577 on AIEDielect.cpp

@jgmelber jgmelber self-assigned this Mar 6, 2024
@stephenneuendorffer stephenneuendorffer added good first issue Good for newcomers quality Improve code quality: maintainability, cleanup, code reorganization. labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgmelber jgmelber

Labels
good first issue Good for newcomers quality Improve code quality: maintainability, cleanup, code reorganization.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stephenneuendorffer @SamuelBayliss @jgmelber