Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.16 Windows Clients lose tray icons when scaling #1100

Closed
totaam opened this issue Jan 27, 2016 · 16 comments
Closed

0.16 Windows Clients lose tray icons when scaling #1100

totaam opened this issue Jan 27, 2016 · 16 comments

Comments

@totaam
Copy link
Collaborator

totaam commented Jan 27, 2016

Issue migrated from trac ticket # 1100

component: client | priority: major | resolution: fixed

2016-01-27 23:55:03: maxmylyn created the issue


Follow up from #976.

Client is 16.X Windows 8.1 11739, and the server is a 16.X Fedora 23 r11764 built from source:

  • Scaling up or down causes the windows to disappear from the tray and re-appear(expected) without their old icons (not-expected.)

  • Reconnecting will get the icons back, but again, upon scaling they are lost.

@totaam
Copy link
Collaborator Author

totaam commented Jan 27, 2016

2016-01-27 23:55:51: maxmylyn edited the issue description

@totaam
Copy link
Collaborator Author

totaam commented Jan 27, 2016

2016-01-27 23:55:51: maxmylyn commented


(edited server version, my session info reported the wrong version)

@totaam
Copy link
Collaborator Author

totaam commented Feb 2, 2016

2016-02-02 05:56:51: antoine changed owner from antoine to maxmylyn

@totaam
Copy link
Collaborator Author

totaam commented Feb 2, 2016

2016-02-02 05:56:51: antoine edited the issue description

@totaam
Copy link
Collaborator Author

totaam commented Feb 2, 2016

2016-02-02 05:56:51: antoine commented


r11812 fixes a bug to do with the systray detected location, which may fix your problem.
I'm not sure since I was not able to reproduce it: although the location was wrong, the systray icon was still visible and still responded to clicks (tested with vlc).
If you can still reproduce the problem, please include more details: maybe a screenshot would help, xpra info always does.

This sounds similar to a number of entries in #976: #976#comment:14, r10802, etc..

@totaam
Copy link
Collaborator Author

totaam commented Feb 4, 2016

2016-02-04 17:56:20: maxmylyn changed owner from maxmylyn to antoine

@totaam
Copy link
Collaborator Author

totaam commented Feb 4, 2016

2016-02-04 17:56:20: maxmylyn commented


Upped client to trunk r11819 Win8.1, EDIT: and server to trunk r11834:

  • Still an issue

  • Will attach screenshot (of the whole desktop...) and Xpra info

Pass back to me if you need anything else.

@totaam
Copy link
Collaborator Author

totaam commented Feb 4, 2016

2016-02-04 17:56:50: maxmylyn uploaded file 1100xprainfo.txt (162.9 KiB)

Xpra info as requested

@totaam
Copy link
Collaborator Author

totaam commented Feb 4, 2016

2016-02-04 18:00:09: maxmylyn uploaded file 1100 desktop screenshot.png (1310.9 KiB)

re-upload of the screenshot minus Skype and Email inboxes...
1100 desktop screenshot.png

@totaam
Copy link
Collaborator Author

totaam commented Feb 4, 2016

2016-02-04 18:06:00: maxmylyn commented


Update:

  • I can now get this issue with a trunk r11834 Fedora 23 client (haven't tried it as much as my monitor doesn't default scale on that machine..)

@totaam
Copy link
Collaborator Author

totaam commented Feb 4, 2016

2016-02-04 18:08:38: maxmylyn uploaded file 1100 Fedora 23 client.png (1257.4 KiB)

Screenshot of the Fedora 23 desktop (XFCE)
1100 Fedora 23 client.png

@totaam
Copy link
Collaborator Author

totaam commented Feb 4, 2016

2016-02-04 19:00:50: antoine changed owner from antoine to maxmylyn

@totaam
Copy link
Collaborator Author

totaam commented Feb 4, 2016

2016-02-04 19:00:50: antoine commented


Should be fixed in r11835: we save the last window icon and restore it when we re-init the window. Will backport.
(this may also have affected suspend + resume / screensaver detection, which also re-inits the windows: #980)

Please confirm and close. (new beta win32 and Fedora 23 builds are available)

@totaam
Copy link
Collaborator Author

totaam commented Feb 12, 2016

2016-02-12 23:41:27: maxmylyn changed status from new to closed

@totaam
Copy link
Collaborator Author

totaam commented Feb 12, 2016

2016-02-12 23:41:27: maxmylyn set resolution to fixed

@totaam
Copy link
Collaborator Author

totaam commented Feb 12, 2016

2016-02-12 23:41:27: maxmylyn commented


Tested with the new Windows trunk build r11890:

All working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant