Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pixbuf backend does not support transparency with desktop scaling enabled #1145

Closed
totaam opened this issue Mar 15, 2016 · 18 comments
Closed

Comments

@totaam
Copy link
Collaborator

totaam commented Mar 15, 2016

Issue migrated from trac ticket # 1145

component: client | priority: major | resolution: fixed

2016-03-15 10:19:39: retog created the issue


Most part of the terminal (using xfce4-terminal and terminator) appear black, mainly when the terminal has the focus. I just updated to ubuntu xenial and xpra 0.17.0 both on the client and on the
server (server being a docker container) but the problem is still there. As display manager normally using i3 but the problem also occurs with the standard ubuntu display manager.

I have been experiencing the problem on different ubuntu and fedora versions on different machines including virtual box vms.

On the server side I run a docker container based on https://github.com/retog/docker-dev.

@totaam
Copy link
Collaborator Author

totaam commented Mar 15, 2016

2016-03-15 10:20:00: retog uploaded file xpra-report.zip (261.9 KiB)

@totaam
Copy link
Collaborator Author

totaam commented Mar 15, 2016

2016-03-15 10:33:33: retog commented


Just found that the problem does not occur when starting with --opengl=yes.

The Sesssion Info - Features shows

Client OpenGL (checked) Intel Open Source Technology Center /Mesa DRI Intel (R) HD graphics 520 (Skylake GT2)

Without the parameter (i.e. when the problem occurs):

Client OpenGL (unchecked) PyOpenGL version 3.1 or later is required (found version 3.0.2)

@totaam
Copy link
Collaborator Author

totaam commented Mar 15, 2016

2016-03-15 10:37:14: antoine commented


It is probably transparency related, the cairo backend does not get as much testing. And there are issues with virtualbox too.
PyOpenGL 3.1 has been out for years... so we're not going to support anything older than that.

@totaam
Copy link
Collaborator Author

totaam commented Mar 15, 2016

2016-03-15 11:48:43: retog commented


As even the newest ubuntu distro comes with a too old PyOpenGL version the installation instructions should say how to get a compatible version.

@totaam
Copy link
Collaborator Author

totaam commented Mar 16, 2016

2016-03-16 03:54:38: antoine changed status from new to assigned

@totaam
Copy link
Collaborator Author

totaam commented Mar 16, 2016

2016-03-16 03:54:38: antoine changed title from Text not appearing in terminals to pixbuf backend does not support transparency with desktop scaling enabled

@totaam
Copy link
Collaborator Author

totaam commented Mar 16, 2016

2016-03-16 03:54:38: antoine commented


As even the newest ubuntu distro comes with a too old PyOpenGL version the installation instructions should say how to get a compatible version.
[[BR]]
You should not be messing up with your system installed packages if you don't know how to do that and how to revert it later.

We should just make sure the non-opengl fallback works as it should.
r12148 fixes that by disabling transparency for the non-opengl gtk pixbuf + cairo case, this will be backported to v0.16.x

I am keeping this ticket open because we should really support transparency with cairo, but not a huge priority.

@totaam
Copy link
Collaborator Author

totaam commented Mar 16, 2016

2016-03-16 07:15:55: retog commented


You should not be messing up with your system installed packages

I did not! I installed xpra following exactly the instruction on unmodified ubuntu installations (including xenial).

@totaam
Copy link
Collaborator Author

totaam commented Jul 12, 2016

2016-07-12 17:52:23: antoine commented


Milestone renamed

@totaam
Copy link
Collaborator Author

totaam commented Aug 10, 2016

2016-08-10 04:36:06: antoine changed status from assigned to closed

@totaam
Copy link
Collaborator Author

totaam commented Aug 10, 2016

2016-08-10 04:36:06: antoine set resolution to wontfix

@totaam
Copy link
Collaborator Author

totaam commented Aug 10, 2016

2016-08-10 04:36:06: antoine commented


I did not! I installed xpra following exactly the instruction on unmodified ubuntu installations (including xenial).
[[BR]]
I meant that if your distro supplies an outdated pyopengl, you should not try to install a newer one on top.

In any case, the non-opengl backends are legacy and therefore I am not going to spend time fixing the desktop-scaling + transparency + non-opengl combination.
Especially since most distros will have opengl support in the next release, including outdated Debian + Ubuntu, see #1275.

@totaam
Copy link
Collaborator Author

totaam commented Jul 10, 2017

2017-07-10 07:36:11: antoine commented


r16261 re-enables transparency with the pixmap backend since I am no longer seeing any visual corruption with desktop-scaling enabled.
Even the cairo backend seems to paint transparency+scaling just fine (both in GTK3 #640 and with GTK2 and XPRA_USE_CAIRO_BACKING=1 env switch).

These changes are now tracked in #1570.

@totaam
Copy link
Collaborator Author

totaam commented Jul 10, 2017

2017-07-10 12:28:34: antoine changed status from closed to reopened

@totaam
Copy link
Collaborator Author

totaam commented Jul 10, 2017

2017-07-10 12:28:34: antoine removed resolution (was wontfix)

@totaam
Copy link
Collaborator Author

totaam commented Jul 10, 2017

2017-07-10 12:29:40: antoine changed status from reopened to closed

@totaam
Copy link
Collaborator Author

totaam commented Jul 10, 2017

2017-07-10 12:29:40: antoine set resolution to fixed

@totaam
Copy link
Collaborator Author

totaam commented Jul 10, 2017

2017-07-10 12:29:40: antoine commented


Tested OK on a number of different OS and backend combinations:

  • debian stretch
  • fedora 26
  • ubuntu 16.04
  • ubuntu 17.04
  • mac os
  • windows...

Works fine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant