Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS betas do not seem to include the latest code? #1695

Closed
totaam opened this issue Nov 23, 2017 · 3 comments
Closed

macOS betas do not seem to include the latest code? #1695

totaam opened this issue Nov 23, 2017 · 3 comments

Comments

@totaam
Copy link
Collaborator

totaam commented Nov 23, 2017

Issue migrated from trac ticket # 1695

component: platforms | priority: major | resolution: worksforme | keywords: macOS

2017-11-23 23:18:48: RayDonn created the issue


I wanted to investigate the jerky trackpad motion and enabled --debug=all on the latest beta:

Xpra --version
xpra v2.2-[r17470](../commit/3626ea7c89d4db56ae4aa4a262173e36d915e24c)

In the logs I can see:

wheel view=140336647457344, deltaX=0.000000, deltaY=1.000000, wheel_event_handler=<bound method Delegate.wheel_event_handler of <Delegate: 0x7fa2a738e9d0>>

I then had a look through the code using the blame feature (using this URL: https://www.xpra.org/trac/browser/xpra/trunk/src/xpra/platform/darwin/gdk_bindings.pyx?annotate=blame ) .. there I see:

[16563]	94	            precise = getPreciseScrollingDeltas(nsevent)
        95	            log("wheel view=%i, deltaX=%f, deltaY=%f, precise=%s, wheel_event_handler=%s", <uintptr_t> view, deltaX, deltaY, precise, wheel_event_handler)

So I am wondering why SVN commit has precise=%s in the code while that is missing from the logs in v2.2-r17470.

I guess I am misunderstanding what code goes into the builds here?

@totaam
Copy link
Collaborator Author

totaam commented Nov 24, 2017

2017-11-24 03:46:17: antoine commented


You are correct, r16563 is when this code was added and it is still current..
The version you have (v2.2-[r17470](../commit/3626ea7c89d4db56ae4aa4a262173e36d915e24c)) should be showing this message!
I have just tried it on my test system with the exact same version and I do see the message:

Xpra --version
xpra v2.2-[r17470](../commit/3626ea7c89d4db56ae4aa4a262173e36d915e24c)
Xpra attach tcp://host:port/ -d osx
(..)
wheel view=140389688987952, deltaX=0.000000, deltaY=-4.800293, precise=0, \
    wheel_event_handler=<bound method Delegate.wheel_event_handler of <Delegate: 0x7faf06a1eaf0>>

Maybe you have multiple versions installed and somehow macos is picking up the libraries from the wrong one?
No idea why it would get the version number correctly though.. there have been a number of issues with macos mis-handling multiple copies of the same application installed on the same system.
I would suggest deleting every copy you can find of anything related to xpra, then re-installing this version. And try swapping the DMG for the PKG, or vice versa. I've tried both, and both worked here.

FYI: for debugging this, "-d osx,mouse,pointer" should be enough, "-d all" is a bit much!

@totaam
Copy link
Collaborator Author

totaam commented Nov 24, 2017

For reference, here's the original feature ticket: #1157

@totaam
Copy link
Collaborator Author

totaam commented Nov 30, 2017

I don't know how I managed to get it in such a state but after a fresh install it's fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant