Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch for bandwidth detection #1912

Closed
totaam opened this issue Jul 8, 2018 · 3 comments
Closed

switch for bandwidth detection #1912

totaam opened this issue Jul 8, 2018 · 3 comments

Comments

@totaam
Copy link
Collaborator

totaam commented Jul 8, 2018

See #999, #1855 and #1911.

We should make it easier to disable bandwidth detection, from the client.
Not sure if we should turn off detection if the server or client supplies a limit already.

@totaam
Copy link
Collaborator Author

totaam commented Jul 8, 2018

Mostly done in r19878 + r19880, the server and client can set the detection on or off (still defaults to on):

xpra attach --mmap=no --bandwidth-detection=no

And the value can be seen with:

$ xpra info | grep bandwidth-limit.detection
client.bandwidth-limit.detection=False

@totaam
Copy link
Collaborator Author

totaam commented Jul 10, 2018

r19905 adds a "Turn off" option to the congestion notification actions.

It would be nice to add a similar option to the client's system tray menu, but this would require:

  • forwarding the flag from server to client via "settings-changed" mechanism
  • syncing that with a new menu-entry
  • augmenting the "bandwidth-limit" request packet with this new flag to allow the client to toggle at will

@totaam
Copy link
Collaborator Author

totaam commented Oct 1, 2018

Too late for 2.4, moving the UI bits to #1972

@maxmylyn: FYI, this new switch makes it easier to rule out problems with the bandwidth detection code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant