Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let applications tell us about their content type #2023

Closed
totaam opened this issue Nov 2, 2018 · 9 comments
Closed

let applications tell us about their content type #2023

totaam opened this issue Nov 2, 2018 · 9 comments
Labels
encoding enhancement New feature or request v2.4.x

Comments

@totaam
Copy link
Collaborator

totaam commented Nov 2, 2018

Issue migrated from trac ticket # 2023

component: server | priority: major | resolution: fixed

2018-11-02 12:10:45: antoine created the issue


Rather than guessing (#1950), the application can tell us exactly what it is doing.

@totaam
Copy link
Collaborator Author

totaam commented Nov 2, 2018

2018-11-02 12:39:33: antoine commented


Done in r20908.

See also #1952#comment:5

@nathan_lstc: you may want to set the "video" content-type on your video windows, and "text" or "picture" on the other ones.

@totaam
Copy link
Collaborator Author

totaam commented Nov 15, 2018

2018-11-15 22:11:51: nathan_lstc commented


Is there an easy way to set content-type on startup for programs that don't set their own window properties?

I'm working on getting our developers to implement this, but so far it's not done yet.

@totaam
Copy link
Collaborator Author

totaam commented Nov 16, 2018

2018-11-16 03:12:09: antoine commented


Is there an easy way to set content-type on startup for programs that don't set their own window properties?

You can set the default content-type for all windows with:

XPRA_DEFAULT_CONTENT_TYPE=video

(or "text" or whatever)
But that's a bad idea as it applies to ALL windows.

A better way is to use the window title or window class (see #1950, ie: [/browser/xpra/trunk/src/content-type]), or the desktop file's category mechanism: #1956

@totaam
Copy link
Collaborator Author

totaam commented Nov 16, 2018

2018-11-16 17:34:53: nathan_lstc commented


I've found that

xprop -format _XPRA_CONTENT_TYPE 8s -set _XPRA_CONTENT_TYPE video

lets me click on the window and set the property. I've also sent some example code for doing this programatically in WxWidgets to our developers, Still waiting to hear back from them.

In the meantime the above command is good enough. I can tell my users to do that.

Is there a way to tell XPRA to us NVENC only on the window with that property set? Is there, perhaps, a smarter way to sidestep the 2 NVENC encoder limitation on GTX?

Nathan

@totaam
Copy link
Collaborator Author

totaam commented Nov 16, 2018

2018-11-16 18:27:20: nathan_lstc commented


Using the "xwininfo" command I think I can even track down the "subwindow" that has the OpenGL (I could be mistaken on this point). If it is, in fact, a "subwindow", does XPRA read it's properties or does it only read properties on windows managed by the window manager (that have _NET_WM_WINDOW_TYPE set)?

If my question is nonsense, please forgive me (and let me know). I'm new to all this.

@totaam
Copy link
Collaborator Author

totaam commented Nov 16, 2018

2018-11-16 18:49:03: antoine commented


Is there a way to tell XPRA to us NVENC only on the window with that property set?
Not at present, but you could set the other windows to "text" which would make it far less likely that they would end up using a video encoder. (see r21020)

Is there, perhaps, a smarter way to sidestep the 2 NVENC encoder limitation on GTX?
Find some license keys. (gdb rwatch is your friend ;)

If it is, in fact, a "subwindow", does XPRA read it's properties or does it only read properties on windows managed by the window manager (that have _NET_WM_WINDOW_TYPE set)?
Xpra is the window manager...
To know which windows xpra is managing, you can use:

$ xpra info | grep xid

It will only read the _XPRA_CONTENT_TYPE property on the windows it manages (those it has an xid for) and not any of their children. (their parent should be an xpra corral window for non-OR windows)

@totaam
Copy link
Collaborator Author

totaam commented Nov 26, 2018

2018-11-26 09:31:16: antoine commented


@maxmylyn: this may be of interest, otherwise just close it.

@totaam
Copy link
Collaborator Author

totaam commented Nov 26, 2018

2018-11-26 17:12:50: maxmylyn commented


I'll pass a note along. Closing.

@totaam totaam closed this as completed Nov 26, 2018
@totaam
Copy link
Collaborator Author

totaam commented Dec 19, 2018

2018-12-19 01:28:32: antoine commented


Related tweaks:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
encoding enhancement New feature or request v2.4.x
Projects
None yet
Development

No branches or pull requests

1 participant