Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rock and route filters based on user comments #251

Closed
paetz opened this issue Sep 16, 2021 · 4 comments
Closed

Rock and route filters based on user comments #251

paetz opened this issue Sep 16, 2021 · 4 comments
Labels
epic A bigger task that consists of many sub issues

Comments

@paetz
Copy link
Collaborator

paetz commented Sep 16, 2021

It would be very helpful to have more filters that match expectations on comments, e.g.:

  • Show me all routes with:
    -- quality >= "lohnend"
    -- humidity >= "normal abtrocknend"
    -- "VIIc" <= grade <= "IXa"
    -- ...
  • Show me all rocks with:
    -- importance >= "lohnender Gipfel"

where we should use the arithmetic mean of the comments if there are more than one available.

The filters for routes must be combinable. Default for one filter is that all values are allowed.

ToDo:

Pre-requirements:

  1. Add rock, project and botch search to rock view options menu #257
  2. Remove filter spinner on Rock and Route view and re-add storable OnlyOfficialSummits and OnlyOfficialRoutes checkbox #260
  3. Proper update of selected rock list on resuming #265
  4. New view SelectedRoutes #255
  5. Add project and botch filter to Route view #259
  6. Global route search #256

Feature:

  1. Add filter Relevance to rock filter dialog #268
  2. Add filter Quality to route filter dialog #270
  3. Add filter SubjectiveGrade to route filter dialog #271
  4. Add filter Protection to route filter dialog #272
  5. Add filter Drying to route filter dialog #273
@paetz paetz added the epic A bigger task that consists of many sub issues label Sep 16, 2021
@chrgernoe
Copy link
Member

If we introduce a sub-menu, I would also move the search field to this sub-menu or maybe move the info button to the menu and add a search button instead.

@paetz
Copy link
Collaborator Author

paetz commented Sep 16, 2021

...or maybe even better: leaving only sync/delete in the menu and creating a filter button next to the info button. This might be the most consistent solution but would necessitate a new separate filter view that contains all filters.

@paetz
Copy link
Collaborator Author

paetz commented Sep 20, 2021

After experimenting a bit, it seems the easiest to have everything in an options menu. This means, every activity from country to route will have its own (specific) options menu:

  • Country/Region/Sector: all items
  • Rock: all without "Aktualisieren" and "Löschen"
  • Route: all without "Aktualisieren", "Löschen" and "Felsen suchen"

The filters should be part of the dialog that opens by clicking on "Felsen suchen" menu item (or "Wege suchen" (to be added), respectively).
As a consequence, the filter spinners from rock and route activity become obsolete and can be replaced by the former checkbox "Nur offizielle Gipfel" and "Nur offizielle Wege", respectively.

If nobody complains, I will adapt the ticket description accordingly.

Open question: How to provide objective grade filtering?

  • Only filter in Saxon grade?
  • Only providing a subjective grade filter based on comments (which are all saxon grade)?
  • Letting the user set grade filters as string to cover other grade systems, too?
    In my eyes, it might make sense to have an editable text field that provides a spinner for saxon grade selection as well as direct string editing.

@chrgernoe
Copy link
Member

The filters should be part of the dialog that opens by clicking on "Felsen suchen" menu item (or "Wege suchen" (to be added), respectively).

I see two features here:

  • The first one is the combination of search and filter, as implemented right now.
  • The second feature is to just filter the view and this selection should be stored until it is changed again. So it would be possible to see always e.g. "Offizielle Gipfel" only.

Open question: How to provide objective grade filtering?

My first idea was the implementation of a spinner but with a central configurable scale system. In this case the app would just translate the systems in each other. However, after thinking a bit more about this feature, I see the problem that the grade is a free text field in the database which makes the filtering not really reliable. I think, to make this feature really useful, we need support from the database side to make clear to which system the grade belongs to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic A bigger task that consists of many sub issues
Projects
None yet
Development

No branches or pull requests

2 participants