Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websocket-Handshake Doesn't Work #2109

Closed
2 tasks done
TheGitMagician opened this issue Nov 5, 2023 · 6 comments
Closed
2 tasks done

Websocket-Handshake Doesn't Work #2109

TheGitMagician opened this issue Nov 5, 2023 · 6 comments
Assignees
Labels
runner-bug In-game bugs with the "GameMaker Studio 2" runtimes
Milestone

Comments

@TheGitMagician
Copy link

TheGitMagician commented Nov 5, 2023

Bug.zip

Description

In 2023.8 you cannot establish a connection between client and server on a websocket basis (network_type_ws).

The server console output reads:

Client(1) Connected: ::ffff:127.0.0.1
WARNING: Discarding malformed data on socket 1 - are you mixing raw/non-raw network APIs?

The exact same project works fine in GM 2023.4.

Expected Change

No response

Steps To Reproduce

  1. Start the attached demo project in two IDEs
  2. Run the program with the Windows target and start the server (left-click)
  3. Run the program with the HTML5 target and start the client (right-click)
  4. Watch the console output of the IDE that started the server
  5. The connection will not be created and the server output will read "Discarding malformed data".

How reliably can you recreate this issue using your steps above?

Always

Which version of GameMaker are you reporting this issue for?

2023.8.2 (Monthly)

Which platform(s) are you seeing the problem on?

Windows, HTML5

Contact Us Package Attached?

  • I have attached my Contact Us Package

Sample Project Added?

  • I have included a small sample project
@TheGitMagician TheGitMagician added the runner-bug In-game bugs with the "GameMaker Studio 2" runtimes label Nov 5, 2023
@vitawrap
Copy link

vitawrap commented Jan 5, 2024

still broken in 2023.11.1.129 (same platforms, HTML and Windows)

@TheGitMagician
Copy link
Author

Can confirm - still broken. Need this fixed.

@yoyo-danielc yoyo-danielc added this to the 2024.2 milestone Jan 9, 2024
@caitlinrmcintyre
Copy link

Verified fix in IDE v2024.200.0.461 Runtime v2024.200.0.477, thanks.

@vitawrap
Copy link

It seems an HTML5 app communicating to a native app with websockets hangs the server after an albeit successful handshake now...

@yoyo-danielc
Copy link

It seems an HTML5 app communicating to a native app with websockets hangs the server after an albeit successful handshake now...

Can you supply a test project for this? Using the project from #4363 (comment), the HTML5 client connects to the server running under Win32, they exchange a couple of messages and both continue to run - the server can still respond to further connections.

@vitawrap
Copy link

It seems an HTML5 app communicating to a native app with websockets hangs the server after an albeit successful handshake now...

Can you supply a test project for this? Using the project from #4363 (comment), the HTML5 client connects to the server running under Win32, they exchange a couple of messages and both continue to run - the server can still respond to further connections.

ah on the test project actually works if i replace all map accesses with ds_map_find_value. this was probably a codegen issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
runner-bug In-game bugs with the "GameMaker Studio 2" runtimes
Projects
Archived in project
Development

No branches or pull requests

4 participants