Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snippet preview triggers visibility of inactive sites in frontend menus #272

Closed
2 tasks done
vixe76 opened this issue Jun 6, 2019 · 3 comments · Fixed by #275
Closed
2 tasks done

Snippet preview triggers visibility of inactive sites in frontend menus #272

vixe76 opened this issue Jun 6, 2019 · 3 comments · Fixed by #275

Comments

@vixe76
Copy link

vixe76 commented Jun 6, 2019

  • I've read and understood the contribution guidelines.
  • I've searched for any related issues and avoided creating a duplicate issue.

Please give us a description of what happened.

After editing a page with Snippet Preview all inactive pages are generally shown in the frontend menus (also for none logged in users).

I suspect the problem is that the Snippet Preview generates a new page cache after editing this page for the logged in BE user.

Please describe what you expected to happen and why.

Showing inactive pages links in frontend (without BE login) should be never allowed.

How can we reproduce this behavior?

  1. Make a page inactive inside a frontend menu
  2. Edit another page which contains the affected menu
  3. Look at the frontend of the edited page and the inactivated page is in the menu visible

Technical info

  • TYPO3 version: 9.5.7
  • Yoast SEO version: 5.0.1
@vixe76
Copy link
Author

vixe76 commented Jun 13, 2019

Hello and sorry for pushing this, but I think this is an urgent bug and for me the extension is not usable in production environments! Can't believe that I'm the only one who is affected!?

Please let me know if additional informations are needed.

Best Regards
Falk

@RinyVT RinyVT mentioned this issue Jun 14, 2019
2 tasks
@RinyVT
Copy link
Collaborator

RinyVT commented Jun 14, 2019

Hi @vixe76
This problem was due to the Middleware setting the Visibility scope so it's possible to preview hidden pages in the backend.
Could you test if this PR fixes your problem?
#275

@vixe76
Copy link
Author

vixe76 commented Jun 17, 2019

Hi @RinyVT
I've tested successfully your PR ... fixes my problem!

Thanks and Greetings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants