Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Story: Fix Modal story after forwardRef was added #4

Open
vraja-pro opened this issue Jan 17, 2023 · 0 comments
Open

Story: Fix Modal story after forwardRef was added #4

vraja-pro opened this issue Jan 17, 2023 · 0 comments
Labels
documentation Improvements or additions to documentation

Comments

@vraja-pro
Copy link

vraja-pro commented Jan 17, 2023

In the issue Yoast/wordpress-seo#19607 forwardRef was added to the Modal component.
When using forward Ref we need to create a story component for the story book because the forwardRef removed the component name and also hides the props from storybook prop table.

Please also check for more usages of components in the storybook and which imports they use. For example the ErrorBoundary, notice the [object Object] in the Show code:
Image

(Thanks Petar for finding and mentioning this!)

@d-claassen d-claassen changed the title Fix Modal story after forwardRef was added Story: Fix Modal story after forwardRef was added Feb 10, 2023
@d-claassen d-claassen added the documentation Improvements or additions to documentation label Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants