ydb_env_set preserves ydb_gbldir/gtmgbldir and ydb_routines/gtmroutines

[ksbhaskar]

Final Release Note

Values of environment variables ydb_gbldir/gtmgbldir and ydb_routines/gtmroutines set before sourcing ydb_env_set are preserved. The ydb_* versions of the environment variables is used if both ydb_* and gtm* versions are defined. (#197)

Description

The ydb_env_set command overrides any previous value set for the ydb_routines and gtmroutines environment variable. This is a regression from the gtmprofile file, which did not, and which the new file was intended to replace.

$ echo $ydb_routines $gtmroutines
/tmp/tmp1 /tmp/tmp2
$ . /usr/local/lib/yottadb/r120/ydb_env_set
$ echo $ydb_routines $gtmroutines
/home/user/.yottadb/r1.20_x86_64/o*(/home/user/.yottadb/r1.20_x86_64/r /home/user/.yottadb/r) /usr/local/lib/yottadb/r120/libyottadbutil.so /home/user/.yottadb/r1.20_x86_64/o*(/home/user/.yottadb/r1.20_x86_64/r /home/user/.yottadb/r) /usr/local/lib/yottadb/r120/libyottadbutil.so
$ 

ydb_gbldir is also affected.

Draft Release Note

ydb_gbldir/gtmgbldir and ydb_routines/gtmroutines set before running ydb_env_set are preserved. The ydb_* versions of the environment variables is used if both ydb_* and gtm* versions are defined.

[ChristopherEdwards]

Is the intention is to have the script NOT modify $ydb_gbldir and $ydb_routines/$gtmroutines (so after the script runs they are the same values they were before the script ran?

[ksbhaskar]

Yes, if they are set going in, then leave them unchanged. If they are not set, then set them to the defaults. – Bhaskar

…

On 05/07/2018 11:36 AM, Christopher Edwards wrote: Is the intention is to have the script NOT modify $ydb_gbldir and $ydb_routines/$gtmroutines (so after the script runs they are the same values they were before the script ran? — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#197 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAiqesBXKIUhHcyb5EHFqi-KjbTssPNwks5twGn4gaJpZM4TNA7J>.

-- YottaDB - Rock solid. Lightning fast. Secure. Pick any three.

[ksbhaskar]

The original idea was that if $ydb_gbldir and $ydb_routines had a pattern matching $ydb_rel from another release, or $gtmver from a GT.M version, that ydb_env_set would replace the pattern with $ydb_rel for the current release. If you can do that reliably, then I think it's worth doing it. Otherwise, make the simplistic fix below. – Bhaskar

…

On 05/07/2018 11:38 AM, K.S. Bhaskar wrote: Yes, if they are set going in, then leave them unchanged. If they are not set, then set them to the defaults. – Bhaskar On 05/07/2018 11:36 AM, Christopher Edwards wrote: > > Is the intention is to have the script NOT modify $ydb_gbldir and > $ydb_routines/$gtmroutines (so after the script runs they are the > same values they were before the script ran? > > — > You are receiving this because you were assigned. > Reply to this email directly, view it on GitHub > <#197 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAiqesBXKIUhHcyb5EHFqi-KjbTssPNwks5twGn4gaJpZM4TNA7J>. > -- YottaDB - Rock solid. Lightning fast. Secure. Pick any three.

-- YottaDB - Rock solid. Lightning fast. Secure. Pick any three.

[ChristopherEdwards]

Thanks!

[ChristopherEdwards]

Pull request #238 resolves this and is merged.