Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ydb_* environment variables to drive operation of ydbinstall.sh script #221

Closed
ChristopherEdwards opened this issue Apr 30, 2018 · 0 comments
Assignees
Milestone

Comments

@ChristopherEdwards
Copy link
Collaborator

ChristopherEdwards commented Apr 30, 2018

Final Release Note

The ydbinstall.sh script uses environment variables ydb_buildtype, ydb_dryrun, ydb_gtm, ydb_group_restriction, ydb_keep_obj, ydb_lcase_utils, ydb_overwrite_existing, ydb_prompt_for_group, and ydb_verbose to drive its operation, corresponding to the environment variables gtm_buildtype, gtm_dryrun, gtm_gtm, gtm_group_restriction, gtm_keep_obj, gtm_lcase_utils, gtm_overwrite_existing, gtm_prompt_for_group, and gtm_verbose. The latter remain supported, with the proviso that if a ydb_ prefixed environment and the corresponding gtm_ prefixed environment variable are both defined, the former takes precedence. (#221)

Description

The installation script ydbinstall.sh uses gtm* environment variables to control certain behavior:

  • gtm_buildtype
  • gtm_keep_obj
  • gtm_dryrun
  • gtm_group_restriction
  • gtm_gtm
  • gtm_lcase_utils
  • gtm_overwrite_existing
  • gtm_prompt_for_group
  • gtm_verbose

There should be ydb* equivalents for these environment variables (in addition to keeping the gtm equivalents for backwards compatibility). This makes the entire environment consistent using ydb* environment variables instead of relying upon the backwards compatibility.

Draft Release Note

The ydbinstall script used gtm* environment variables to control certain operations:

  • gtm_buildtype
  • gtm_keep_obj
  • gtm_dryrun
  • gtm_group_restriction
  • gtm_gtm
  • gtm_lcase_utils
  • gtm_overwrite_existing
  • gtm_prompt_for_group
  • gtm_verbose

These are replaced by ydb prefixed versions:

  • ydb_buildtype
  • ydb_keep_obj
  • ydb_dryrun
  • ydb_group_restriction
  • ydb_gtm
  • ydb_lcase_utils
  • ydb_overwrite_existing
  • ydb_prompt_for_group
  • ydb_verbose

The new environment variables are functionally equivalent to the old ones, just with a different prefix.

@nars1 nars1 added this to the r130 milestone May 2, 2018
ChristopherEdwards added a commit to ChristopherEdwards/YottaDB that referenced this issue May 8, 2018
The ydbinstall.sh script uses environment variables to control certain advanced
functionality of the script. These were previously gtm prefixed variables,
but for consistency purposes they should be ydb prefixed variables.

Modify the ydbinstall.sh script to look for ydb prefixed variables
and set the corresponding internal variable to the value of the ydb
prefixed variable, while mantaining backwards compatibility with gtm
prefixed variables.
ChristopherEdwards added a commit that referenced this issue May 8, 2018
The ydbinstall.sh script uses environment variables to control certain advanced
functionality of the script. These were previously gtm prefixed variables,
but for consistency purposes they should be ydb prefixed variables.

Modify the ydbinstall.sh script to look for ydb prefixed variables
and set the corresponding internal variable to the value of the ydb
prefixed variable, while mantaining backwards compatibility with gtm
prefixed variables.
@ksbhaskar ksbhaskar changed the title ydbinstall.sh uses gtm* environment variables ydb_* environment variables to drive operation of ydbinstall.sh script May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants