Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor slack config #95

Open
Yukaii opened this issue Mar 2, 2023 · 0 comments
Open

Refactor slack config #95

Yukaii opened this issue Mar 2, 2023 · 0 comments
Labels
good first issue Good for newcomers

Comments

@Yukaii
Copy link
Owner

Yukaii commented Mar 2, 2023

zuzugo/lib/config.ts

Lines 40 to 49 in a2222fa

slackWebhook,
slackAppToken: process.env.SLACK_APP_TOKEN,
slackBotToken: process.env.SLACK_BOT_TOKEN,
slackSigningSecret: process.env.SLACK_SIGNING_SECRET,
slackDevMode: process.env.SLACK_DEV_MODE === "true",
slackClientId: process.env.SLACK_CLIENT_ID,
slackClientSecret: process.env.SLACK_CLIENT_SECRET,
slackStateSecret: process.env.SLACK_STATE_SECRET,
slackRedirectUri: process.env.SLACK_REDIRECT_URI,
slackSlashCommand: process.env.SLACK_SLASH_COMMAND,

Refactor to scoped config like:

slack: {
  incomingWebhook: process.env.INCOMING_WEBHOOK,
  ...
}
@Yukaii Yukaii converted this from a draft issue Mar 2, 2023
@Yukaii Yukaii added the good first issue Good for newcomers label Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: Backlog
Development

No branches or pull requests

1 participant