Upgrade loses admin key from config.js

[webmink]

Describe the bug

When running any upgrade to CryptPad on Yunohost, the admin key is lost from config.js

Context

• Hardware: Raspberry Pi 4
• YunoHost version: 11.1.15
• I have access to my server: Through SSH | through the webadmin | direct access via keyboard / screen
• Are you in a special context or did you perform some particular tweaking on your YunoHost instance?: no
• If upgrading, current package version: 5.2.1~ynh6

Steps to reproduce

• Click "System Update" in Yunohost admin screen
• Request pending upgrade to CryptPad
• On completion config.js has been replaced with a vanilla version with no admin key so no administration is possible without manual edits of config.js

Expected behavior

Install should preserve admin key and perhaps some other changes to config.js that are necessary for normal operation

Logs

https://paste.yunohost.org/raw/atukamafes

[webmink]

Potential fix: #185

[Ddataa]

yes it is under construction...

[webmink]

Did this get integrated in the recent release? I still had to update my admin key when I upgraded...

[tituspijean]

It has been implemented in #185, but somehow disappeared from the code later. In any case, the ynh_read_var_in_file helper does not seem to be able to read that variable. Maybe we need to have a configuration panel for that?