New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix minor issues in ZRC2 ->ERC20 contract #721

Open

rrw-zilliqa opened this issue Jul 29, 2024 · 0 comments

Assignees

Contributor

rrw-zilliqa commented Jul 29, 2024

... reported by HashLock:

SafeMath is the default in Solidity 0.8.x
Replace _UINT8_MAX and _UINT256_MAX definitions with the Solidity symbolic constants.
_UINT8_MAX should be of type uint8
Make immutable variables immutable

rrw-zilliqa self-assigned this

rrw-zilliqa mentioned this issue

Address some minor issues in the ZRC2->ERC20 proxy, add tests and verification. #729

Merged

rrw-zilliqa closed this as completed

rrw-zilliqa reopened this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment