feat: constrain (r, s, v) signature values #259
Merged
Commits on Mar 20, 2024
-
add check_vmsign_tryRecover test
Sort of an integration test to make sure that the (v, r, s) values we generate can be encoded and decoded properly in ECDSA.tryRecover
Commits on Mar 23, 2024
-
feat: constrain (r, s, v) signature values
(to their expected range)
-
-
-
fix extract_bytes in case of empty calldata
+ document missing feature in our implementation of ecrecover
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.