From d00ade337f82dd875b544711b9ab175ffe869c73 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niclas=20Ro=C3=9Fberger?= Date: Thu, 21 Nov 2019 19:13:49 +0100 Subject: [PATCH 1/5] moves Classes to more fitting packages --- .../kgraphql/schema/dsl/ResolverDSL.kt | 1 + .../kgraphql/schema/dsl/SchemaBuilder.kt | 15 ++++-- .../{ => operations}/QueryOrMutationDSL.kt | 7 ++- .../dsl/{ => operations}/SubscriptionDSL.kt | 16 +++++-- .../dsl/{ => types}/BooleanScalarDSL.kt | 2 +- .../schema/dsl/{ => types}/DoubleScalarDSL.kt | 2 +- .../schema/dsl/{ => types}/EnumDSL.kt | 5 +- .../schema/dsl/{ => types}/EnumValueDSL.kt | 4 +- .../schema/dsl/{ => types}/InputTypeDSL.kt | 3 +- .../schema/dsl/{ => types}/InputValueDSL.kt | 3 +- .../schema/dsl/{ => types}/InputValuesDSL.kt | 2 +- .../schema/dsl/{ => types}/IntScalarDSL.kt | 2 +- .../schema/dsl/{ => types}/LongScalarDSL.kt | 2 +- .../schema/dsl/{ => types}/ScalarDSL.kt | 3 +- .../schema/dsl/{ => types}/StringScalarDSL.kt | 2 +- .../schema/dsl/{ => types}/TypeDSL.kt | 8 +++- .../schema/dsl/{ => types}/UnionTypeDSL.kt | 3 +- .../schema/model/MutableSchemaDefinition.kt | 46 ++++++++++--------- .../language/OperationsSpecificationTest.kt | 9 ++-- 19 files changed, 84 insertions(+), 51 deletions(-) rename kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/{ => operations}/QueryOrMutationDSL.kt (93%) rename kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/{ => operations}/SubscriptionDSL.kt (85%) rename kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/{ => types}/BooleanScalarDSL.kt (95%) rename kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/{ => types}/DoubleScalarDSL.kt (95%) rename kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/{ => types}/EnumDSL.kt (78%) rename kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/{ => types}/EnumValueDSL.kt (56%) rename kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/{ => types}/InputTypeDSL.kt (73%) rename kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/{ => types}/InputValueDSL.kt (84%) rename kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/{ => types}/InputValuesDSL.kt (90%) rename kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/{ => types}/IntScalarDSL.kt (94%) rename kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/{ => types}/LongScalarDSL.kt (94%) rename kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/{ => types}/ScalarDSL.kt (89%) rename kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/{ => types}/StringScalarDSL.kt (95%) rename kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/{ => types}/TypeDSL.kt (94%) rename kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/{ => types}/UnionTypeDSL.kt (78%) diff --git a/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/ResolverDSL.kt b/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/ResolverDSL.kt index d3ff9801..a433b7a8 100644 --- a/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/ResolverDSL.kt +++ b/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/ResolverDSL.kt @@ -1,5 +1,6 @@ package com.apurebase.kgraphql.schema.dsl +import com.apurebase.kgraphql.schema.dsl.types.InputValuesDSL import com.apurebase.kgraphql.schema.model.InputValueDef diff --git a/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/SchemaBuilder.kt b/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/SchemaBuilder.kt index 927a1240..88295595 100644 --- a/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/SchemaBuilder.kt +++ b/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/SchemaBuilder.kt @@ -1,14 +1,19 @@ package com.apurebase.kgraphql.schema.dsl -import com.apurebase.kgraphql.schema.* +import com.apurebase.kgraphql.schema.Publisher +import com.apurebase.kgraphql.schema.Schema +import com.apurebase.kgraphql.schema.SchemaException +import com.apurebase.kgraphql.schema.dsl.operations.QueryOrMutationDSL +import com.apurebase.kgraphql.schema.dsl.operations.SubscriptionDSL +import com.apurebase.kgraphql.schema.dsl.types.* +import com.apurebase.kgraphql.schema.model.EnumValueDef +import com.apurebase.kgraphql.schema.model.MutableSchemaDefinition +import com.apurebase.kgraphql.schema.model.TypeDef +import com.apurebase.kgraphql.schema.structure.SchemaCompilation import com.fasterxml.jackson.core.JsonParser import com.fasterxml.jackson.databind.DeserializationContext import com.fasterxml.jackson.databind.deser.std.StdDeserializer import com.fasterxml.jackson.databind.module.SimpleModule -import com.apurebase.kgraphql.schema.model.EnumValueDef -import com.apurebase.kgraphql.schema.model.TypeDef -import com.apurebase.kgraphql.schema.model.MutableSchemaDefinition -import com.apurebase.kgraphql.schema.structure.SchemaCompilation import kotlin.reflect.KClass /** diff --git a/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/QueryOrMutationDSL.kt b/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/operations/QueryOrMutationDSL.kt similarity index 93% rename from kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/QueryOrMutationDSL.kt rename to kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/operations/QueryOrMutationDSL.kt index e458a9cf..5830765b 100644 --- a/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/QueryOrMutationDSL.kt +++ b/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/operations/QueryOrMutationDSL.kt @@ -1,6 +1,8 @@ -package com.apurebase.kgraphql.schema.dsl +package com.apurebase.kgraphql.schema.dsl.operations import com.apurebase.kgraphql.Context +import com.apurebase.kgraphql.schema.dsl.LimitedAccessItemDSL +import com.apurebase.kgraphql.schema.dsl.ResolverDSL import com.apurebase.kgraphql.schema.model.FunctionWrapper import com.apurebase.kgraphql.schema.model.InputValueDef import com.apurebase.kgraphql.schema.model.MutationDef @@ -11,7 +13,8 @@ import kotlin.reflect.KFunction class QueryOrMutationDSL( val name : String, private val block : QueryOrMutationDSL.() -> Unit -) : LimitedAccessItemDSL(), ResolverDSL.Target { +) : LimitedAccessItemDSL(), + ResolverDSL.Target { private val inputValues = mutableListOf>() diff --git a/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/SubscriptionDSL.kt b/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/operations/SubscriptionDSL.kt similarity index 85% rename from kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/SubscriptionDSL.kt rename to kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/operations/SubscriptionDSL.kt index 1826ec28..22733149 100644 --- a/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/SubscriptionDSL.kt +++ b/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/operations/SubscriptionDSL.kt @@ -1,8 +1,15 @@ -package com.apurebase.kgraphql.schema.dsl +package com.apurebase.kgraphql.schema.dsl.operations import com.apurebase.kgraphql.Context -import com.apurebase.kgraphql.schema.* -import com.apurebase.kgraphql.schema.model.* +import com.apurebase.kgraphql.schema.Publisher +import com.apurebase.kgraphql.schema.SchemaException +import com.apurebase.kgraphql.schema.Subscriber +import com.apurebase.kgraphql.schema.Subscription +import com.apurebase.kgraphql.schema.dsl.LimitedAccessItemDSL +import com.apurebase.kgraphql.schema.dsl.ResolverDSL +import com.apurebase.kgraphql.schema.model.FunctionWrapper +import com.apurebase.kgraphql.schema.model.InputValueDef +import com.apurebase.kgraphql.schema.model.SubscriptionDef import com.fasterxml.jackson.databind.ObjectWriter import kotlin.reflect.full.isSubtypeOf import kotlin.reflect.full.memberProperties @@ -12,7 +19,8 @@ import kotlin.reflect.full.starProjectedType class SubscriptionDSL( val name : String, block : SubscriptionDSL.() -> Unit -) : LimitedAccessItemDSL(), ResolverDSL.Target { +) : LimitedAccessItemDSL(), + ResolverDSL.Target { private val inputValues = mutableListOf>() diff --git a/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/BooleanScalarDSL.kt b/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/types/BooleanScalarDSL.kt similarity index 95% rename from kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/BooleanScalarDSL.kt rename to kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/types/BooleanScalarDSL.kt index 9393d176..53b7d794 100644 --- a/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/BooleanScalarDSL.kt +++ b/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/types/BooleanScalarDSL.kt @@ -1,4 +1,4 @@ -package com.apurebase.kgraphql.schema.dsl +package com.apurebase.kgraphql.schema.dsl.types import com.apurebase.kgraphql.schema.SchemaException import com.apurebase.kgraphql.schema.model.ast.ValueNode diff --git a/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/DoubleScalarDSL.kt b/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/types/DoubleScalarDSL.kt similarity index 95% rename from kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/DoubleScalarDSL.kt rename to kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/types/DoubleScalarDSL.kt index ef427153..1541fa2e 100644 --- a/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/DoubleScalarDSL.kt +++ b/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/types/DoubleScalarDSL.kt @@ -1,4 +1,4 @@ -package com.apurebase.kgraphql.schema.dsl +package com.apurebase.kgraphql.schema.dsl.types import com.apurebase.kgraphql.schema.SchemaException import com.apurebase.kgraphql.schema.model.ast.ValueNode diff --git a/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/EnumDSL.kt b/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/types/EnumDSL.kt similarity index 78% rename from kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/EnumDSL.kt rename to kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/types/EnumDSL.kt index 66e44064..e2695d03 100644 --- a/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/EnumDSL.kt +++ b/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/types/EnumDSL.kt @@ -1,6 +1,7 @@ -package com.apurebase.kgraphql.schema.dsl +package com.apurebase.kgraphql.schema.dsl.types import com.apurebase.kgraphql.defaultKQLTypeName +import com.apurebase.kgraphql.schema.dsl.ItemDSL import kotlin.reflect.KClass @@ -19,7 +20,7 @@ class EnumDSL>(kClass: KClass, block : (EnumDSL.() -> Unit)?) } infix fun T.describe(content: String){ - valueDefinitions[this] = EnumValueDSL(this){ + valueDefinitions[this] = EnumValueDSL(this) { description = content } } diff --git a/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/EnumValueDSL.kt b/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/types/EnumValueDSL.kt similarity index 56% rename from kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/EnumValueDSL.kt rename to kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/types/EnumValueDSL.kt index 1f4f5f84..22fdbe95 100644 --- a/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/EnumValueDSL.kt +++ b/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/types/EnumValueDSL.kt @@ -1,4 +1,6 @@ -package com.apurebase.kgraphql.schema.dsl +package com.apurebase.kgraphql.schema.dsl.types + +import com.apurebase.kgraphql.schema.dsl.DepreciableItemDSL class EnumValueDSL>(val value : T, block : EnumValueDSL.() -> Unit) : DepreciableItemDSL(){ diff --git a/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/InputTypeDSL.kt b/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/types/InputTypeDSL.kt similarity index 73% rename from kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/InputTypeDSL.kt rename to kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/types/InputTypeDSL.kt index d02bc292..ac113cc0 100644 --- a/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/InputTypeDSL.kt +++ b/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/types/InputTypeDSL.kt @@ -1,6 +1,7 @@ -package com.apurebase.kgraphql.schema.dsl +package com.apurebase.kgraphql.schema.dsl.types import com.apurebase.kgraphql.defaultKQLTypeName +import com.apurebase.kgraphql.schema.dsl.ItemDSL import kotlin.reflect.KClass diff --git a/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/InputValueDSL.kt b/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/types/InputValueDSL.kt similarity index 84% rename from kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/InputValueDSL.kt rename to kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/types/InputValueDSL.kt index fcd9c95a..23d010c0 100644 --- a/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/InputValueDSL.kt +++ b/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/types/InputValueDSL.kt @@ -1,5 +1,6 @@ -package com.apurebase.kgraphql.schema.dsl +package com.apurebase.kgraphql.schema.dsl.types +import com.apurebase.kgraphql.schema.dsl.DepreciableItemDSL import com.apurebase.kgraphql.schema.model.InputValueDef import kotlin.reflect.KClass diff --git a/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/InputValuesDSL.kt b/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/types/InputValuesDSL.kt similarity index 90% rename from kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/InputValuesDSL.kt rename to kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/types/InputValuesDSL.kt index 66a6f6cc..b60b4888 100644 --- a/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/InputValuesDSL.kt +++ b/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/types/InputValuesDSL.kt @@ -1,4 +1,4 @@ -package com.apurebase.kgraphql.schema.dsl +package com.apurebase.kgraphql.schema.dsl.types import kotlin.reflect.KClass diff --git a/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/IntScalarDSL.kt b/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/types/IntScalarDSL.kt similarity index 94% rename from kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/IntScalarDSL.kt rename to kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/types/IntScalarDSL.kt index e6d5911a..1fbd9ba0 100644 --- a/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/IntScalarDSL.kt +++ b/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/types/IntScalarDSL.kt @@ -1,4 +1,4 @@ -package com.apurebase.kgraphql.schema.dsl +package com.apurebase.kgraphql.schema.dsl.types import com.apurebase.kgraphql.schema.SchemaException import com.apurebase.kgraphql.schema.model.ast.ValueNode diff --git a/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/LongScalarDSL.kt b/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/types/LongScalarDSL.kt similarity index 94% rename from kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/LongScalarDSL.kt rename to kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/types/LongScalarDSL.kt index 3eca61e7..fab48950 100644 --- a/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/LongScalarDSL.kt +++ b/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/types/LongScalarDSL.kt @@ -1,4 +1,4 @@ -package com.apurebase.kgraphql.schema.dsl +package com.apurebase.kgraphql.schema.dsl.types import com.apurebase.kgraphql.schema.SchemaException import com.apurebase.kgraphql.schema.model.ast.ValueNode diff --git a/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/ScalarDSL.kt b/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/types/ScalarDSL.kt similarity index 89% rename from kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/ScalarDSL.kt rename to kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/types/ScalarDSL.kt index 4b127050..4d09e4e9 100644 --- a/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/ScalarDSL.kt +++ b/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/types/ScalarDSL.kt @@ -1,6 +1,7 @@ -package com.apurebase.kgraphql.schema.dsl +package com.apurebase.kgraphql.schema.dsl.types import com.apurebase.kgraphql.defaultKQLTypeName +import com.apurebase.kgraphql.schema.dsl.ItemDSL import com.apurebase.kgraphql.schema.scalar.ScalarCoercion import kotlin.reflect.KClass diff --git a/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/StringScalarDSL.kt b/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/types/StringScalarDSL.kt similarity index 95% rename from kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/StringScalarDSL.kt rename to kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/types/StringScalarDSL.kt index 5c3cf540..34ad0338 100644 --- a/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/StringScalarDSL.kt +++ b/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/types/StringScalarDSL.kt @@ -1,4 +1,4 @@ -package com.apurebase.kgraphql.schema.dsl +package com.apurebase.kgraphql.schema.dsl.types import com.apurebase.kgraphql.schema.SchemaException import com.apurebase.kgraphql.schema.model.ast.ValueNode diff --git a/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/TypeDSL.kt b/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/types/TypeDSL.kt similarity index 94% rename from kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/TypeDSL.kt rename to kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/types/TypeDSL.kt index 89e2cec6..1dc5907c 100644 --- a/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/TypeDSL.kt +++ b/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/types/TypeDSL.kt @@ -1,11 +1,15 @@ -package com.apurebase.kgraphql.schema.dsl +package com.apurebase.kgraphql.schema.dsl.types import com.apurebase.kgraphql.defaultKQLTypeName import com.apurebase.kgraphql.schema.SchemaException +import com.apurebase.kgraphql.schema.dsl.ItemDSL +import com.apurebase.kgraphql.schema.dsl.KotlinPropertyDSL +import com.apurebase.kgraphql.schema.dsl.PropertyDSL +import com.apurebase.kgraphql.schema.dsl.UnionPropertyDSL import com.apurebase.kgraphql.schema.model.FunctionWrapper import com.apurebase.kgraphql.schema.model.PropertyDef -import com.apurebase.kgraphql.schema.model.TypeDef import com.apurebase.kgraphql.schema.model.Transformation +import com.apurebase.kgraphql.schema.model.TypeDef import kotlin.reflect.KClass import kotlin.reflect.KProperty1 diff --git a/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/UnionTypeDSL.kt b/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/types/UnionTypeDSL.kt similarity index 78% rename from kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/UnionTypeDSL.kt rename to kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/types/UnionTypeDSL.kt index 2b9917c9..ab286c2c 100644 --- a/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/UnionTypeDSL.kt +++ b/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/types/UnionTypeDSL.kt @@ -1,5 +1,6 @@ -package com.apurebase.kgraphql.schema.dsl +package com.apurebase.kgraphql.schema.dsl.types +import com.apurebase.kgraphql.schema.dsl.ItemDSL import kotlin.reflect.KClass diff --git a/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/model/MutableSchemaDefinition.kt b/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/model/MutableSchemaDefinition.kt index c1648b88..403adbf5 100644 --- a/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/model/MutableSchemaDefinition.kt +++ b/kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/model/MutableSchemaDefinition.kt @@ -5,13 +5,8 @@ import com.apurebase.kgraphql.schema.SchemaException import com.apurebase.kgraphql.schema.builtin.BUILT_IN_TYPE import com.apurebase.kgraphql.schema.directive.Directive import com.apurebase.kgraphql.schema.directive.DirectiveLocation -import com.apurebase.kgraphql.schema.dsl.TypeDSL -import com.apurebase.kgraphql.schema.introspection.TypeKind -import com.apurebase.kgraphql.schema.introspection.__Directive -import com.apurebase.kgraphql.schema.introspection.__EnumValue -import com.apurebase.kgraphql.schema.introspection.__Field -import com.apurebase.kgraphql.schema.introspection.__Schema -import com.apurebase.kgraphql.schema.introspection.__Type +import com.apurebase.kgraphql.schema.dsl.types.TypeDSL +import com.apurebase.kgraphql.schema.introspection.* import kotlin.reflect.KClass import kotlin.reflect.full.isSubclassOf @@ -146,35 +141,42 @@ data class MutableSchemaDefinition ( } } -private fun create__TypeDefinition() = TypeDSL(emptyList(), __Type::class){ - transformation(__Type::fields){ fields: List<__Field>?, includeDeprecated : Boolean? -> +private fun create__TypeDefinition() = TypeDSL(emptyList(), __Type::class) { + transformation(__Type::fields) { fields: List<__Field>?, includeDeprecated: Boolean? -> if (includeDeprecated == true) fields else fields?.filterNot { it.isDeprecated } } - transformation(__Type::enumValues){ enumValues: List<__EnumValue>?, includeDeprecated: Boolean? -> + transformation(__Type::enumValues) { enumValues: List<__EnumValue>?, includeDeprecated: Boolean? -> if (includeDeprecated == true) enumValues else enumValues?.filterNot { it.isDeprecated } } }.toKQLObject() -private fun create__DirectiveDefinition() = TypeDSL(emptyList(), __Directive::class){ - property("onField"){ +private fun create__DirectiveDefinition() = TypeDSL( + emptyList(), + __Directive::class +) { + property("onField") { resolver { dir: __Directive -> dir.locations.contains(DirectiveLocation.FIELD) } deprecate("Use `locations`.") } - property("onFragment"){ - resolver { dir: __Directive -> dir.locations.containsAny ( - DirectiveLocation.FRAGMENT_SPREAD, - DirectiveLocation.FRAGMENT_DEFINITION, - DirectiveLocation.INLINE_FRAGMENT) + property("onFragment") { + resolver { dir: __Directive -> + dir.locations.containsAny( + DirectiveLocation.FRAGMENT_SPREAD, + DirectiveLocation.FRAGMENT_DEFINITION, + DirectiveLocation.INLINE_FRAGMENT + ) } deprecate("Use `locations`.") } - property("onOperation"){ - resolver{ dir : __Directive -> dir.locations.containsAny ( - DirectiveLocation.QUERY, - DirectiveLocation.MUTATION, - DirectiveLocation.SUBSCRIPTION) + property("onOperation") { + resolver { dir: __Directive -> + dir.locations.containsAny( + DirectiveLocation.QUERY, + DirectiveLocation.MUTATION, + DirectiveLocation.SUBSCRIPTION + ) } deprecate("Use `locations`.") } diff --git a/kgraphql/src/test/kotlin/com/apurebase/kgraphql/specification/language/OperationsSpecificationTest.kt b/kgraphql/src/test/kotlin/com/apurebase/kgraphql/specification/language/OperationsSpecificationTest.kt index 8cbdc947..c8c1fef6 100644 --- a/kgraphql/src/test/kotlin/com/apurebase/kgraphql/specification/language/OperationsSpecificationTest.kt +++ b/kgraphql/src/test/kotlin/com/apurebase/kgraphql/specification/language/OperationsSpecificationTest.kt @@ -1,9 +1,12 @@ package com.apurebase.kgraphql.specification.language -import com.apurebase.kgraphql.* +import com.apurebase.kgraphql.Specification +import com.apurebase.kgraphql.defaultSchema +import com.apurebase.kgraphql.executeEqualQueries +import com.apurebase.kgraphql.expect import com.apurebase.kgraphql.schema.SchemaException -import com.apurebase.kgraphql.schema.dsl.subscribe -import com.apurebase.kgraphql.schema.dsl.unsubscribe +import com.apurebase.kgraphql.schema.dsl.operations.subscribe +import com.apurebase.kgraphql.schema.dsl.operations.unsubscribe import org.amshove.kluent.shouldEqual import org.junit.Test From 85d0f820fb3086d5071eba0d62ae2e63d291478b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niclas=20Ro=C3=9Fberger?= Date: Thu, 21 Nov 2019 19:36:55 +0100 Subject: [PATCH 2/5] moves block() outside of the DSL class --- .idea/runConfigurations/Run_Tests.xml | 23 ------ .../kotlin/com/apurebase/kgraphql/KGraphQL.kt | 7 +- .../kgraphql/schema/dsl/ResolverDSL.kt | 2 +- .../kgraphql/schema/dsl/SchemaBuilder.kt | 82 ++++++++++--------- ...MutationDSL.kt => AbstractOperationDSL.kt} | 41 +--------- .../schema/dsl/operations/MutationDSL.kt | 26 ++++++ .../schema/dsl/operations/QueryDSL.kt | 25 ++++++ .../schema/dsl/operations/SubscriptionDSL.kt | 56 ++++--------- .../schema/dsl/types/BooleanScalarDSL.kt | 3 +- .../schema/dsl/types/DoubleScalarDSL.kt | 3 +- .../kgraphql/schema/dsl/types/EnumDSL.kt | 10 +-- .../kgraphql/schema/dsl/types/EnumValueDSL.kt | 6 +- .../kgraphql/schema/dsl/types/InputTypeDSL.kt | 6 +- .../schema/dsl/types/InputValueDSL.kt | 6 +- .../schema/dsl/types/InputValuesDSL.kt | 7 +- .../kgraphql/schema/dsl/types/IntScalarDSL.kt | 3 +- .../schema/dsl/types/LongScalarDSL.kt | 3 +- .../kgraphql/schema/dsl/types/ScalarDSL.kt | 4 +- .../schema/dsl/types/StringScalarDSL.kt | 3 +- .../kgraphql/schema/dsl/types/TypeDSL.kt | 6 +- .../kgraphql/schema/dsl/types/UnionTypeDSL.kt | 6 +- .../schema/model/MutableSchemaDefinition.kt | 4 +- .../com/apurebase/kgraphql/TestUtils.kt | 10 ++- 23 files changed, 146 insertions(+), 196 deletions(-) delete mode 100644 .idea/runConfigurations/Run_Tests.xml rename kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/operations/{QueryOrMutationDSL.kt => AbstractOperationDSL.kt} (59%) create mode 100644 kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/operations/MutationDSL.kt create mode 100644 kgraphql/src/main/kotlin/com/apurebase/kgraphql/schema/dsl/operations/QueryDSL.kt diff --git a/.idea/runConfigurations/Run_Tests.xml b/.idea/runConfigurations/Run_Tests.xml deleted file mode 100644 index 301bfc22..00000000 --- a/.idea/runConfigurations/Run_Tests.xml +++ /dev/null @@ -1,23 +0,0 @@ - - - - - -