New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use typedefs instead macros definitions when some type alias declared #68

Open

kuler94 opened this issue Feb 19, 2019 · 0 comments

kuler94 commented Feb 19, 2019

Better use typedef or using keyword instead of macro definitions in places like this https://github.com/aappleby/smhasher/blob/master/src/PMurHash.h#L46 to prevent user's namespaces pollution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment