Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add incentives data provider #19

Merged
merged 56 commits into from
Nov 1, 2021
Merged

feat: add incentives data provider #19

merged 56 commits into from
Nov 1, 2021

Conversation

defispartan
Copy link
Contributor

@defispartan defispartan commented Sep 28, 2021 •
edited
Loading

Create a context to fetch reserve and user incentives data from UiIncentiveDataProvider contract.

Calculate incentives APYs and total claimable rewards using aave-utilities helper functions.

Update TopIncentiveBalance and RewardConfirm to support view/claim multiple incentive tokens

defispartan and others added 15 commits September 27, 2021 23:50
@defispartan
feat: add aave-utilities packages
bfb563c
@defispartan
feat: add UiIncentiveDataProvider configurations
0c7100e
@defispartan
feat: add hook to fetch and format incentive data from UiIncentiveDat…
c41f34f 
…aProvider contract
@defispartan
feat: add context for reserve asset incentives and total claimable re…
9813e0e 
…wards for user
@defispartan
feat: add incentives context to main App
18d0b64
@sendra
feat: generated gql schemas for incentives cache resolvers
a6cdaad
@sendra
feat: wip: add cache integration
6c1289f
@sendra
feat: incentives cache done
a336c6f
@sendra
fix: added missing type
07ffa68
@sendra
Merge pull request #21 from aave/feat/incentives-cache
10bedda 
feat: generated gql schemas for incentives cache resolvers
@sendra @defispartan
feat: cache client integrated (#22)
90317ed 
* feat: added cache data and mixed with rpc data. missing to solve some types

* fix: fixed user rewards type

* fixed reserves type

* feat: update incentives context with latest helper functions

* feat: updated iIncentiveDatProvider contract interface

Co-authored-by: Andrew Schmidt <[email protected]>
@defispartan
feat: split reserve and user incentive data fetching
576ad57
@defispartan
feat: update claimableRewards outside of useEffect and fix decimal ty…
895f0e0 
…pe issue
@defispartan
feat: replace incentive data source with new context
478e097
@defispartan
feat: update user reward claim components with new context
ea442c6
@sakulstra sakulstra changed the title Feat/add incentives data provider feat: add incentives data provider Oct 4, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2021

Preview link: https://cloudflare-ipfs.com/ipfs/QmNUT9L9VfyM1HW8BiK5KsDKEw74GcubRNET79hzMgGY1x

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2021

Preview link: https://cloudflare-ipfs.com/ipfs/QmXML9BqBATS9iLETBhfGSvkahGF9fMEhSm8tZEQofmxrJ

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2021

Preview link: https://cloudflare-ipfs.com/ipfs/QmNdg1NPgKT248MoPzkeE5khZGC9wdcenH1UUzH72qouF7

@github-actions
Copy link
Contributor

Preview link: https://cloudflare-ipfs.com/ipfs/QmVjj7qqmUVBYiucymHMDj9jUDj5ZgaMwYxqS2fSc5dnuv

@github-actions
Copy link
Contributor

Preview link: https://cloudflare-ipfs.com/ipfs/QmfLNrkZfbcMKd5QZL41oiDzAwjJyhXn9xs7N6JoyZVNxE

@github-actions
Copy link
Contributor

Preview link: https://cloudflare-ipfs.com/ipfs/QmXTxVXZFsc48A8icHGg4ByvzAnhHJVtFU7fcYCwQa3Atk

@github-actions
Copy link
Contributor

Preview link: https://cloudflare-ipfs.com/ipfs/QmRw5m2ZKwKtQsxZWz6svXkQt2eLerAu5bvaGtRiQqQMzf

1 similar comment
@github-actions
Copy link
Contributor

Preview link: https://cloudflare-ipfs.com/ipfs/QmRw5m2ZKwKtQsxZWz6svXkQt2eLerAu5bvaGtRiQqQMzf

@MareskoY
Copy link
Contributor

there are a few bugs

BUG1:
claim block disappears after withdrawing all assets

steps:

  1. make a deposit
  2. withdraw the deposit
  3. move to dashboard page

result:

  • block with reward does not show

2021-10-28 13_25_46-Window

after refresh page, this block come back

BUG2:
in big resolutions, there is a UI issue with the new UI implementation of the reward block

2021-10-28 13_26_11-Window

@github-actions
Copy link
Contributor

Preview link: https://cloudflare-ipfs.com/ipfs/Qmciz3V16APyKZunpbVuMmFWKSXfLpuyq2iZ8LCfwsM5QC

@github-actions
Copy link
Contributor

Preview link: https://cloudflare-ipfs.com/ipfs/Qmciz3V16APyKZunpbVuMmFWKSXfLpuyq2iZ8LCfwsM5QC

1 similar comment
@github-actions
Copy link
Contributor

Preview link: https://cloudflare-ipfs.com/ipfs/Qmciz3V16APyKZunpbVuMmFWKSXfLpuyq2iZ8LCfwsM5QC

@github-actions
Copy link
Contributor

Preview link: https://cloudflare-ipfs.com/ipfs/QmX1xcy821otNEEyzfwBr1XcsBDMfWyj3vgQKfNukaCWDY

@MareskoY
Copy link
Contributor

MareskoY commented Nov 1, 2021

QC PASSED

@sakulstra sakulstra merged commit 79891e9 into master Nov 1, 2021
@sakulstra sakulstra deleted the feat/add-incentives-data-provider branch November 1, 2021 12:59
paulcodiny added a commit to paulcodiny/aave-ui that referenced this pull request Feb 20, 2022
@paulcodiny
Merge pull request aave#19 from paulcodiny/feat/dashboard
6d0c314 
feat: dashboard, borrow, modals, wip: stake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sakulstra sakulstra sakulstra approved these changes

@sendra sendra Awaiting requested review from sendra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multi incentive UI incentive claim logic
5 participants
@defispartan @MareskoY @sakulstra @sendra @Argeare5