Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roamer should never delete a file on rename error #18

Open
vimeitor opened this issue Aug 30, 2017 · 1 comment
Open

roamer should never delete a file on rename error #18

vimeitor opened this issue Aug 30, 2017 · 1 comment
Labels

Comments

@vimeitor
Copy link

If renaming one or more files fails, the original file should stay in the original folder; you should never have to go under .roamer-data/ to find it.

I was bitten by this issue accidentally when using a slash on a file's name (which you can't use for obvious reasons). I think it's easy to overlook an error when you are renaming multiple files, and you might not even notice, which was the case for me for quite some time until I was looking for the file and couldn't find it.

Does that sound reasonable?

@abaldwin88 abaldwin88 added the bug label Aug 30, 2017
@abaldwin88
Copy link
Owner

abaldwin88 commented Aug 30, 2017

Yep very reasonable. Thanks for reporting!

EDIT: #16 should help with this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants