Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Instances of Same CSS Block #147

Open
saurabhdaware opened this issue Nov 1, 2022 · 1 comment
Open

Multiple Instances of Same CSS Block #147

saurabhdaware opened this issue Nov 1, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@saurabhdaware
Copy link
Member

Describe the bug

While using a component, if you reuse the component multiple times, it is currently adding inlined CSS of that component multiple times as well

To Reproduce

  • Create a component
  • Import it and call it multiple times

Expected behavior

  • I feel we should add it to a separate CSS file and import the css file.

Screenshots

Specs:

  • Abell Version:
  • Node Version:
  • Operating System:

Additional context

@saurabhdaware saurabhdaware added the bug Something isn't working label Nov 1, 2022
@saurabhdaware
Copy link
Member Author

We'll have to stop appending the css inlined to components and instead extract some sort of css-stats.json file that has css related to a file.

Then we can have some function like collectCSS (similar to stitches, styled-components, and any other css-in-js library) and then generate a css file based on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant