Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode in documentation site #165

Open
saurabhdaware opened this issue Oct 16, 2023 · 3 comments
Open

Dark mode in documentation site #165

saurabhdaware opened this issue Oct 16, 2023 · 3 comments
Labels
enhancement New feature or request P2 Priority Level 2 packages/docs Improvements or additions to documentation

Comments

@saurabhdaware
Copy link
Member

Is your feature request related to a problem? Please describe.

Currently we only added light mode because its better to not have dark mode than having a badly designed dark mode. But at some point we would need a good dark mode since that is expected from documentation sites

Describe the solution you'd like

I think first we'll have to play around colors and decide what type of dark mode we want. A full black dark mode something like vercel? or more like a dim mode?

Opposite to the the current only-light mode, https://v0.abelljs.org had 3 modes - dark, dim, light but then we end up with 3 versions where contrasts and aesthetics get difficult to maintain.

Additional context

This might need few iterations before it goes live on production so the development will likely happen in parallel branch for some time

@saurabhdaware saurabhdaware added enhancement New feature or request packages/docs Improvements or additions to documentation P2 Priority Level 2 labels Oct 16, 2023
@jatingodnani
Copy link

@saurabhdaware we can use daisy ui for dark light mode.

@saurabhdaware
Copy link
Member Author

I was thinking of avoiding tailwindcss in docs unless it becomes a need. Right now the UI is fairly stable so not sure if introducing new library is required. We should be able to achieve dark mode with css variables. The tricky part is designing and using the right colors and not really the dev implementation.

@jatingodnani
Copy link

jatingodnani commented Oct 26, 2023

you can check the different theme in daisy ui then we can implement in simple css variable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2 Priority Level 2 packages/docs Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants